Roslyn: Perhaps rename ArgumentSyntax.RefOrOutKeyword to be RefKindKeyword

Created on 30 Sep 2017 · 6Comments · Source: dotnet/roslyn

In addition to RefKeyword and OutKeyword It can now also have a value InKeyword so perhaps the original name no longer fits.

It would be technically a breaking change though in the APIs

Area-Compilers Concept-API Language-C# Resolution-Fixed Tenet-Compatibility

Source

VSadov

Most helpful comment

well, https://twitter.com/jaredpar/status/880171504926720000

alrz on 30 Sep 2017

👍2

All 6 comments

We can probably manage the breaking change by adding the new API and marking the old one as obsolete.

jcouv on 30 Sep 2017

well, https://twitter.com/jaredpar/status/880171504926720000

alrz on 30 Sep 2017

👍2

Ah, makes sense.
@dotnet/compiler-api Should we just add the better named property (leaving the existing one), or stick with just the existing one?

jcouv on 1 Oct 2017

Could we have "soft" obsolete warnings that does not turn to errors with warnaserror? RefOrOutKeyword is obviously misleading and wouldn't be the last one that needs to be renamed. Even if we add another property, I think it's good to hint the user about the change.

PS: But again, as mentioned elsewhere, warnaserror is for people that "want" to get errors with this kinds of issues. you upgrade a dependency and get some obsolete warnings. I think it's just reasonable.

alrz on 1 Oct 2017

👍1

There is nothing actively harmful or incorrect about the old overload, so I'm not obsoleting anything.