Roslyn: 'Inline rename' adds an extra Attribute string when renaming an attribute

[0xd4d]

Version Used: VS2017 15.3.1

Steps to Reproduce:

Inline rename the attribute below from MyAttribute to eg. XXXAttribute

C# sealed class MyAttribute : Attribute { }

Expected Behavior:

New name is XXXAttribute

Actual Behavior:

New name is XXXAttributeAttribute

[Pilchie]

:link: Also reported at https://developercommunity.visualstudio.com/content/problem/62106/rename-attribute-stuck-with-nameattributeattribute.html

[JustinMinnaar]

Yes, I've encountered this problem too.

[tg73]

Having recently updated to 15.3.1, I'm now seeing the same problem. A workaround is to comment out the base class declaration, rename, and then uncomment the base class declaration.

[agr]

Issue is still present in 15.7.0 Preview 3.0 [27602.0.d15.7]

[Orlys]

I've encountered this problem in version: 15.7.3

[OndrejVrsan]

Workaround:

1. Temporarily comment out inherited Attribute class, so you'll get e.g.
   public sealed class MyAttribute // : Attribute
2. Perform the inline rename
3. Remove the comment so your class inherits Attribute again
   public sealed class MyRenamedAttribute : Attribute

[nvmkpk]

Well better workaround would be to first rename the class and then update references using the light bulb.

[yaroslavboev]

Guys, are you going to fix it? A year has passed already.

[CyrusNajmabadi]

Guys, are you going to fix it? A

@yaroslavboev Are you interesting in contributing a fix? I can help walk you through the areas to look at here to fix this.

A year has passed already.

Time is generally only a small factor in prioritization of issues. In this case, the issue likely being out-prioritized by other work. If you'd like to help contribute here, that would help move things along! :)

[lillo42]

@CyrusNajmabadi I would like to try to fix this issue

[CyrusNajmabadi]

@lillo42 Great! Have you contributed to Roslyn before? Do you have an existing enlistmnet to work out of? Or would you need to get that set up?

[lillo42]

@CyrusNajmabadi I haven't contributed before, I would like to get that set up. Do you recommend some article or something to read before I begin to fix?

[jmarolf]

@lillo42

Here is a basic overview of roslyn to get you started.

Here are instructions on how to build and debug roslyn.

Here is where the inline rename code lives.

You can always ask questions on gitter, team members try to monitor that.

[CyrusNajmabadi]

@jmarolf Thanks much. I was just writing this up. You helped me out a lot finding all these references :)

[lillo42]

@jmarolf @CyrusNajmabadi Thank very much.

[jinujoseph]

also reported here

[mohitsharmaniit11]

@OndrejVrsan Your workaround works thanks, issue still not resolved.

[SaSiNO97]

This issue still exists (at least in the version of Roslyn used by VS Community 2017 15.8.6)

[Neme12]

@SaSiNO97 The fix will be available in VS 2019 Preview 2 (16.0 is the numeric version of VS 2019, just like 15.0 is for 2017), not in 15.8 or 15.9 unfortunately.

[pcc-uk]

Why will this issue not be fixed in 15.9?

[Neme12]

@PCC-UK Sadly, no.

[lostllama]

@Neme12 There was a "Why" at the start of @PCC-UK's question :)

[SieBrum]

This is still an issue, why is this still not fixed?

[CyrusNajmabadi]

@SieBrum

This is still an issue, why is this still not fixed?

Works for me:

[SaSiNO97]

@Neme12 Thanks, I really appreciate the work you are doing