Roslyn-analyzers: Find a better name for MicrosoftCodeAnalysisForShippedApisVersion

Created on 30 Sep 2020  路  4Comments  路  Source: dotnet/roslyn-analyzers

If you need new bits only for test you can bump up the below: https://github.com/dotnet/roslyn-analyzers/blob/193a3b623223f6c4a015d9faafb874fd739dff61/eng/Versions.props#L28

We should probably rename that property name to suggest that is for tests.

_Originally posted by @mavasani in https://github.com/dotnet/roslyn-analyzers/pull/4256#r497693691_

Area-Infrastructure Enhancement help wanted
Source
picture Youssef1313

Most helpful comment

MicrosoftCodeAnalysisVersionForTests?

picture mavasani on 30 Sep 2020
👍2

All 4 comments

Something like MicrosoftCodeAnalysisForShippedApisVersionUsedForUnitTesting seems super long.

Youssef1313 picture Youssef1313 on 30 Sep 2020

MicrosoftCodeAnalysisVersionForTests?

mavasani picture mavasani on 30 Sep 2020
👍2

Sounds good. Even shorter than the original name.

Youssef1313 picture Youssef1313 on 30 Sep 2020

Fixed in #4260

Youssef1313 picture Youssef1313 on 1 Oct 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

paulomorgado picture paulomorgado  路  3Comments
paulomorgado picture paulomorgado  路  3Comments
KrisVandermotten picture KrisVandermotten  路  3Comments
paulomorgado picture paulomorgado  路  3Comments
sharwell picture sharwell  路  4Comments