Roslyn-analyzers: Possibly incorrect CA1067

[onyxmaster]

Analyzer package

Microsoft.CodeAnalysis.FxCopAnalyzers

Package Version

v2.6.3

Diagnostic ID

CA1067

Repro steps

using System;

public class A<T> : IEquatable<T>
    where T : A<T>
{
    public virtual bool Equals(T other) => false;

    public override bool Equals(object obj) => Equals(obj as T);
}

public class B : A<B>
{
}

Expected behavior

No code analysis warnings are produced for class B.

Actual behavior

The definition of class B is annotated with warning CA1067 "Type B should override Equals because it implements IEquatable".

Notes

If I recall correctly, v2.6.2 didn't exhibit this behavior.

[pantosha]

Any news?

In my opinition possible cause of this issue is fix of #1914.

[mavasani]

@pantosha That seems correct. Would you like to contribute a PR to fix it?

[onyxmaster]

Manish, thank you very much for this one, looking forward to new release.