Rocket.chat: Username is static in reactions

[lpilz]

Description:

After importing messages from Slack, the usernames in reactions are not properly connected to the user._ids and thus don't change with differing UI_use_real_name setting or changing usernames.

Steps to reproduce:

1. Do Slack import with reactions
2. Change RC username of one of the reacting users

Expected behavior:

Username in mentions changes with the respective new username and also heeds the UI_use_real_name setting.

Actual behavior:

Username stays the same from import and shows even if UI_use_real_name is true.

Server Setup Information:

• Version of Rocket.Chat Server: 3.2.2
• Operating System: Ubuntu
• Deployment Method: snap
• Number of Running Instances: 1
• DB Replicaset Oplog:
• NodeJS Version: 12.16.1
• MongoDB Version: 3.6.14

Client Setup Information

This is client independent

[gabriellsh]

First reaction:

After editing username

This has nothing to do with slack import. Currently reactions are kept based on their usernames.

[lpilz]

You're completely right. Improving this would require changing the save reactions routine as well as the renderer I guess?

[gabriellsh]

Yeah, probably. Would have to save based on userId and then get the username from the userId on the renderer.

[lpilz]

Great, that doesn't sound too complicated :D One would of course also have to change the importers to reflect this. I currently have a project, but if this is still open when I'm finished, I'd love to take a crack at it...

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dossantg]

The problem is still present in 3.8.0. When UI_use_real_name is true, the username field is always displayed instead of the name field

Can you re-open this issue please?