Rocket.chat: BUG: users with a space in the name cannot be at-mentioned

[ryjones]

Description:

We allow the use of social logins. Users may come in from GitHub, or Google+, for instance and put a space in the username when they sign up. I am unable to at-mention these users.

Server Setup Information:

• Version of Rocket.Chat Server: 3.4.2

Steps to Reproduce:

1. create user with space in name
2. join user to channel
3. attempt to at-mention user
4. User appears in pick list, is chosen

Expected behavior:

1. alert is sent to user with space in name

Actual behavior:

1. no alert is sent

[milesflo]

From the outside looking in, this seems like a concern of input validation...

Consider trimming usernames of whitespace before further validating them?

[ryjones]

@milesflo valid usernames may have spaces, though

[milesflo]

@ryjones No, when I say trim, I mean removing from either end of the string, not filtering whitespace out entirely... Like literally just call trim() as the first step of validating a username before setting it.

[ChameleonScales]

this issue is also discussed in #956, although it deserves its own thread (here).

[Ablesius]

@ryjones No, when I say trim, I mean removing from either end of the string, not filtering whitespace out entirely... Like literally just call trim() as the first step of validating a username before setting it.

How would this apply to white space in the middle of a username, though?

[milesflo]

@ryjones No, when I say trim, I mean removing from either end of the string, not filtering whitespace out entirely... Like literally just call trim() as the first step of validating a username before setting it.

How would this apply to white space in the middle of a username, though?

This post is over a year old 🙂 DW about it

[Ablesius]

Hope you don't mean to say this issue is not going to be resolved. It's been a PITA for at least 2 years.

[ryjones]

This is still a huge problem for Hyperledger; I imagine it impacts other instances as well.

[ryjones]

I don't care any more.

[Ablesius]

It is still an issue for me. Is there a follow-up issue or can we please re-open this one?

[ChameleonScales]

@ryjones You may have authored this issue but since several other people have shown interest in it, not caring anymore yourself is no longer a good enough reason to close it.

[Karreg]

Any news on the subject? We just hit this issue. In France there are a lot of people with spaces in their names... :(

People can't be either invited nor referenced if we don't know their technical ID...

[Ablesius]

After reading the thread on the special characters in the other issue, I get that this problem is a bit bigger, but still, a single whitespace in between two words like "First Last" should work imho.

[ryjones]

@Sing-Li @geekgonecrazy @engelgabriel this is still a huge problem for Hyperledger.

[eig0r]

any update for this issue ?

[Ablesius]

Is anybody even looking into this? Are there some hints for people willing to contribute as to where to even start looking? This issues is still a huge problem for us and we're actually considering dropping rocket.chat. I'd be willing to try and contribute but I'd need some pointers.

[ryjones]

@Ablesius we're also looking for rocket.chat replacements

[geekgonecrazy]

Feels like we should send the mention along with the message instead of purely parsing the sent message server side for a mention. Especially cases like this where client literally auto completes. We wouldn’t have to take client word for a mention if we didn’t want to and scan the message for the mention.