Rocket.chat: Update steffo:meteor-accounts-saml

Created on 30 Jan 2018 · 11Comments · Source: RocketChat/Rocket.Chat

https://github.com/steffow/meteor-accounts-saml

Source

engelgabriel

Most helpful comment

Upgraded from 0.61.0 to 0.62.1.. Now my SAML auth is broken.. Config didn't change

RC configured to connect to Microsoft ADFS 2.0

I now get error

Sorry, an annoying error occured
TypeError: profile.nameIDFormat.indexOf is not a function

megamaced on 6 Mar 2018

👍2

All 11 comments

May be needed for https://github.com/RocketChat/Rocket.Chat/pull/9546

engelgabriel on 30 Jan 2018

Upgraded from 0.61.0 to 0.62.1.. Now my SAML auth is broken.. Config didn't change

RC configured to connect to Microsoft ADFS 2.0

I now get error

Sorry, an annoying error occured
TypeError: profile.nameIDFormat.indexOf is not a function

megamaced on 6 Mar 2018

👍2

@engelgabriel I updated the steffow meteor-saml package, to hotfix the broken SAML since 0.62:

10212 -> fix for release candidate

10210 -> fix for develop

10209 -> fix for master

arminfelder on 25 Mar 2018

❤1

@arminfelder @engelgabriel We have merged a pull request for encrypted assertions into meteor-accounts-saml do you guys see any chance that our changes make it to develop? if so, what would be the optimal way?

gerbsen on 22 Aug 2018

@gerbsen RC uses a slightly modified Version of the meteor-accounts-saml lib, which forces you, to merge it manually, which is ugly, but not too hard.

arminfelder on 23 Aug 2018

Thanks for your response @arminfelder This means we need to change this: https://github.com/RocketChat/Rocket.Chat/tree/develop/packages/meteor-accounts-saml ?

gerbsen on 24 Aug 2018

@gerbsen yes

arminfelder on 24 Aug 2018

👍1

And would you consider merging this, i.e. are PRs welcome here?

gerbsen on 29 Aug 2018

@gerbsen PRs are certainly welcome, but it often takes quite some time get reviewed by someone who is allowed to

arminfelder on 5 Sep 2018

I am using Rocket.Chat 0.74.3 and I am having SLO errors with SAML. When looking at the code I see differences does the latest version of Rocket.Chat have the upstream patches from steffo? Would somebody be willing to help me out: https://github.com/RocketChat/Rocket.Chat/issues/13831

There is still html body generation in a few places in the code, can this be updated as well to be integrated better?

[root@rocketchat01 packages]# fgrep "<body>" steffo_meteor-accounts-saml.js
  let content = '<html><head><script>window.close()</script></head><body><H1>Verified</H1></body></html>';
    content = `<html><body><h2>Sorry, an annoying error occured</h2><div>${err}</div><a onclick="window.close();">Close Window</a></body></html>`;