Rocket.chat: Markdown link which url has `&` has broken

[peccu]

Rocket.Chat Version: 0.54.2
Running Instances: 1
DB Replicaset OpLog: Enables
Node Version: v4.7.1

Markdown link which url has & has broken.

ex:
[url with & has broken](https://demo.rocket.chat/channel/general?test=test&test2=test2)
becomes a link to https://demo.rocket.chat/channel/general?test=test&test2=test2
( & is replaced to & )

I think this is because of 590d120ff16c388a57ad0d78c07e096debca3df7.
So I'll try to fix and create PR.

[thiagoarrais]

Is this live already? I think I've reproduced it in the demo chat today.

Steps to reproduce: Copy and paste this into a rocket chat window:

this is a [mangled link](http://example.com/?q=foo&r=bar)

Expected result: (output html) <a href="http://example.com/?q=foo&r=bar">mangled link</a>

Let me know if you need more info.

[TwizzyDizzy]

@rocket-cat close

Closibg this, as I cannot reproduce this on latest stable version (0.62.2). Please get back to me with additional details if you think this is still the case and I'll happily reopen :)

Cheers
Thomas

[nbuchwitz]

@TwizzyDizzy:
I'm able to reproduce it with 0.63.1 (ac16e938693aa04740758f180f2ea6d7a0337280) - maybe be a regression?

[TwizzyDizzy]

@rocket-cat open

Just reproduced on 0.63.1. Reopening.

Cheers
Thomas

[imeleges]

Unfortunately, it is the same problem on 0.65.1

[tassoevan]

@rodrigok @sampaiodiego Any update? #7454 and #8318 seem to be related to this.

[sampaiodiego]

@tassoevan can you please test https://github.com/RocketChat/Rocket.Chat/pull/8318/ to make sure it properly fixes this issue?

[tassoevan]

As @kaiiiiiiiii said there, it isn't the same issue though it has the same root cause. While working on #11165, I noticed that the current markdown parser need some profound tweaks to render messages reliably. I'll look for suggestions from the community and report to the @RocketChat/frontend team.

[ghosty-be]

issue still present in 0.69.1 ... very annoying since icinga2 also generates this type of URL's with & in between, so alert url in rocketchat are broken :(

[josh0412]

Issue is sadly still present..

[starso]

I have same problem using api to sen messages - every url been sent to rocketchat have ampersant ( & ) is broken - message is cut just after first occurance of &

[tassoevan]

Which markdown parser (Administration > Message > Markdown > Markdown Parser) is causing this?

[starso]

Which markdown parser (Administration > Message > Markdown > Markdown Parser) is causing this?

Original one

[MartinSchoeler]

@starso is this only happening when using the API?

[starso]

@starso is this only happening when using the API?

Yes, If i post message directly with url containing & mark everything is fine.
Using API string gets cut after first occurence of & mark.

[MartinSchoeler]

I've just tested using the API and it seems to be working fine in version 2.3.0-develop please try to use the latest version, and if the problem persists, please open a new issue with updated details and the specific API call that you are using. Thanks!