Rocket.chat.reactnative: Error when trying remove a single member while creating new channel

Created on 2 Mar 2020  路  6Comments  路  Source: RocketChat/Rocket.Chat.ReactNative

  • Your Rocket.Chat Experimental app version: 4.5.0.9999999999
  • Your Rocket.Chat server version: 3.1.0-develop open.rocket.chat
  • Device (or Simulator) you're running with: Android P Samsung Galaxy J6

As the gif shows, when we add members to create a channel, then if we remove them, the last one doesn't get removed. We don't get a message about why we can't remove a single member. Also if we long press on that member item, we get the following error.
ezgif com-crop (4)

Most helpful comment

@sarthakpranesh You're making too many assumptions.
People tend to have different expectations of how a software should behave.
Creating a room without any users is a correct feature and it's available on the web client.

@Prateek93a yep, that's an issue.
You should be able to remove both users on CreateChannelView.

All 6 comments

@diegolmello Hi, I have a doubt here. If we don't select any users in the select user screen and proceed to create a channel, we are able to create it, but if we have selected a user, there is a condition that maintains the minimum number to 1, I am not sure why this condition is used if we can create a new channel even without selecting any user. Thanks

We shouldn't be allowed to make any new channel without any user. :thinking:
I think when we select a user then the flow is correct, but the flow of creating a channel without selecting any user has bugs.

I believe the expected flow should be when someone creates a channel they should be selected by default, this will make sure at least the person creating the channel is there in it or else empty channels won't make sense.

@sarthakpranesh You're making too many assumptions.
People tend to have different expectations of how a software should behave.
Creating a room without any users is a correct feature and it's available on the web client.

@Prateek93a yep, that's an issue.
You should be able to remove both users on CreateChannelView.

@diegolmello Ok, and also along with fixing the error, shall we add a visual indicator that tapping on the member item will remove that member? I didn't know about this until I mistakenly tapped on the member item. Maybe we can have a cross button on the right side indicating that by pressing on the member item. Similarly, on the select users view, we can have a cross on the top right corner of member items on the horizontal list.

@Prateek93a Not a cross, but the same check icon as on SelectUsersView.

Ok

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jacotec picture jacotec  路  5Comments

Perflyst picture Perflyst  路  5Comments

HamzaKhait picture HamzaKhait  路  4Comments

diegolmello picture diegolmello  路  5Comments

fbuchmeier-abi picture fbuchmeier-abi  路  3Comments