Rocket.chat.reactnative: App name and version not set for Rocket.Chats internal statistics

Created on 5 Dec 2019 · 8Comments · Source: RocketChat/Rocket.Chat.ReactNative

Your Rocket.Chat Experimental app version: 1.25.0.13047
Your Rocket.Chat server version: 2.3.0
Device (or Simulator) you're running with: iPad w/ iPad OS 13.2.3

The "user-agent" is working correctly (#1307) and it's showing in the webserver's log:

"RC-RN Mobile/1.25.0 (build: 13047; os: ios 13.2.3)"

And for comparison the old app:

"RC Mobile; iOS 13.2.3; v3.5.2 (262)"

But in Rocket.Chat's internal log it isn't registered correctly:

"uniqueDevicesOfYesterday": {
        "data": [
…
            {
                "count": 1,
                "name": "RC Mobile",
                "time": 89,
                "type": "mobile-app",
                "version": "3.5.0"
            },
…
            {
                "count": 8,
                "time": 838,
                "type": "mobile"
            },
…

It just shows up as type mobile without app name and version.

🍭 good first issue 🐛 bug

Source

phriedrich

👍1

All 8 comments

The statistics you can get from API: https://rocket.chat/docs/developer-guides/rest-api/miscellaneous/statistics/

phriedrich on 5 Dec 2019

👍1

To follow up with what I found out:

Rocket.Chat's statistic module specifically looks for 'RC Mobile' to recognize the app. [1]

But Rocket.Chat.ReactNative sets [2]:

export const headers = { 'User-Agent': `RC-RN Mobile/${ DeviceInfo.getVersion() } (build: ${ DeviceInfo.getBuildNumber() }; os: ${ Platform.OS } ${ DeviceInfo.getSystemVersion() })` };

The Swift app also uses another format [3]:

return "RC Mobile; iOS \(systemVersion); v\(appVersion) (\(bundleVersion))"

phriedrich on 17 Dec 2019

👍1

@phriedrich We're cutting version 4.2 already and we're going to release it soon.
Let's try to fix this on 4.3.
Are you willing to open a PR?
Thanks!