Rocket.chat.electron: [3.0.1] Spell Checker no longer work

[jpele-tis]

• Operating System: Windows 10 version 2004
• App Version: 3.0.1

• Installation type: exe

• [x] I have tested with the latest version

• [x] I can simulate the issue easily

Description

Spell Checker no longer work since 3.x
I've try to add manually disctionnaries in user env and sys env => same problem
Modifying the file for en_US and fr_FR in "C:UsersjpadminAppDataRoamingRocket.ChatPreferences" => same problem

Current Behavior

Option find languages disapear (screen on 2.17.x)

Expected Behavior

Incorrect words should be at least underlined in red.

[AmatorPhasma]

Intresting... same configuration on my end, but it works.: tested with german and french.

[blacklord049]

Try uncheck the langage in the dropdown menu then check it again or do it in another channel ? It worked for me.

[jpele-tis]

Try uncheck the langage in the dropdown menu then check it again or do it in another channel ? It worked for me.

Following thoses steps, I've got the same problem on 2 PCs I've tested.
Reinstalling "properly" additionally do not fix the issue.

[tassoevan]

The dictionaries are downloaded from Google CDN. Is it possible that any download was blocked by some network rule or error?

[ankar84]

The dictionaries are downloaded from Google CDN. Is it possible that any download was blocked by some network rule or error?

Indeed.
I checked en-US in dictionaries list

and here what was after

en-US-9-0.bdic file was downloaded to C:Usersankar84AppDataRoamingRocket.ChatDictionariesen-US-9-0.bdic
and copied to C:Usersankar84AppDataRoamingRocket.Chaten-US-9-0.bdic


And it works perfect.
No need to do something with dictionaries manually

[jpele-tis]

The dictionaries are downloaded from Google CDN. Is it possible that any download was blocked by some network rule or error?

It is surely blocked by our network, we do not plan to open much for Google, where can we download .bdic files manually? We got a powerful SDT (WAPT) so we're able to place them manually.

Additionnaly, it is planned to add an RC option who block Google background downloads ?
Would you consider implementing bdic files in the RC binary?

[ankar84]

Agree with @jpele-tis
Automatic download of selected dictionary it's a really convenient, but there is a lot of companies that block such connections and manual dictionary management it's must have function for such clients.

I believe user need to deal with c:\Users\UserName\AppData\Roaming\Rocket.Chat\Preferences file to configure user dictionaries
{"electron":"spellcheck":{"dictionaries":["ru","en-US"],"dictionary":""}}

And download dictionaries to both folders:
c:\Users\UserName\AppData\Roaming\Rocket.Chat\ c:\Users\UserName\AppData\Roaming\Rocket.Chat\Dictionaries\

[tassoevan]

Would you consider impletmenting bdic files in the RC binary?

Not really, as it would increase the bundle size with unused dictionaries.

Automatic download of selected dictionary it's a really convenient, but there is a lot of companies that block such connections and manual dictionary management it's must have function for such clients.

I'll do a double-check in Electron source, but its docs don't state anything about it. For instance, the only option listed is to host your own dictionaries: https://www.electronjs.org/docs/tutorial/spellchecker#does-the-spellchecker-use-any-google-services

[jpele-tis]

Not really, as it would increase the bundle size with unused dictionaries.

You're right, 350MB of file size will be really overkill for only dictionnaries.

I managed to find the Google repo, enjoy packaging ;)
git clone https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries

[jpele-tis]

Btw, I've packaged RocketChat with dictionnaries in user env (you need the SDT WAPT)
You can get it here : https://store.wapt.fr/store/tis-rocketchat

[Naworm]

So what you plan to do btw @tassoevan ?