Riot: w5100 driver's bug

[liyue75]

In drivers/w5100/w5100.c, line 186:
return (S0_TX_BASE + limit);,
I think it should be:
return (S0_TX_BASE + len - limit);
It returns the position of the last write.

[maribu]

Good catch! Yes, indeed. Do you want to create a pull request to fix this, so that you get the credit for the fix?

[liyue75]

Yes, I do.

[leandrolanzieri]

Release is approaching, it would be a nice moment to get this fix included :-) @liyue75 ?

[liyue75]

Hi @leandrolanzieri That's good to hear! Now I can close this issue.

[maribu]

There seems to be a misunderstanding. I assumed that you, @liyue75, wanted to open a pull request containing the fix you proposed. So far, the issue is not fixed in master.

Are you interested in opening the pull request? If not, I can open one.

[liyue75]

@maribu
Er... I was wrong. Now I create a pull request.
it seems I was wrong again, do I need to add more comments?

[maribu]

Here is a guide on who to contribute code. If you have any questions, feel free to ask here, in the forum, or in the Matrix or IRQ chat room.

Don't feel pushed into this by me - I could also open the pull request if you want. That said, I think this is an excellent opportunity to become member of the RIOT contributors ;-)

[liyue75]

Hi, @maribu. I meet a problem when making a pull request, what is the meaning of "CI: ready for build" label not set?
Is that means it requires administrator review to add label?