Riot: style: notation of hexadecimal numbers (0xAFFE vs 0xaffe)

Created on 27 Nov 2017  路  8Comments  路  Source: RIOT-OS/RIOT

While reviewing #7937, I noticed that we don't have a preferred/default/defined way to note hexadecimal numbers: in the RIOT code base they are as often written using capital letters as they are using lowercase.

I think it would make sense to add a sentence with a preferred style to the coding conventions. Personally I prefer lowercase letters, but this is certainly very subjective. So how about a quick vote: (i) "uppercase", (ii) "lowercase", (iii) "absolutely indifferent and this is a waste of time".

doc

Most helpful comment

I am indifferent. And this is a waste of time. And I really really don't care.

All 8 comments

Why not use Github emoji for the vote ? Let's add a comment for each proposition and people vote the comment they prefer. What do you think ?

I prefer (ii). This is personal taste (and a weird one as well), but uppercase hex look always kind of MS-DOS-y and old-timey [edit]and not the good one, but the old and dusty one[/edit] to me.

@aabadie: alright, we might as well try it. So please vote on one of the tree following:

use uppercase for hexadecimal numbers: 0xAFFE

use lowercase for hexadecimal numbers: 0xaffe

I am indifferent. And this is a waste of time. And I really really don't care.

Please vote only once !

Seems like the majority of people doesn't care, so I take we simply do nothing w.r.t. this topic. Closing this issue again - as always: re-open of anyone disagrees with the outcome.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jcarrano picture jcarrano  路  7Comments

jue89 picture jue89  路  5Comments

gschorcht picture gschorcht  路  7Comments

nikosft picture nikosft  路  6Comments

kaspar030 picture kaspar030  路  3Comments