Rh-che: Recommendations on pom.xml are currently not working

[mlabuda]

I have a Che server running on image rhche/che-server:ba40d4c-fabric8-5bd0962 (15 hours old) and template 1.0.231. There is a env var RECOMMENDER_API_TOKEN, also there is com.redhat.bayesian.lsp agent present in workspace but there is no server.js running in workspace nor working Bayesian. Che server in log contains info about launching bayesian LSP
2017-07-20 09:10:38,699[aceSharedPool-4] [INFO ] [o.e.c.a.w.s.WorkspaceRuntimes 692] - Launching 'com.redhat.bayesian.lsp' agent at workspace workspacex66f4i8nrf48xrqq

[l0rd]

@mlabuda I've changed the title of this issue because it looks like the issue is only for recommendation with pom.xml files. You can find more details below:

WHEN IS BAYESIAN NODE APP STARTED?
Bayesian node app is started only when a file (package.json, pom.xml or requirement.txt) is opened. That explains why you don't see the application after workspace startup. You need to open one of these files first.

ISSUE WITH pom.xml files
Currently recommendation agent is not activated for pom.xml files. That's is a side effect of the rebase we did last week on top of last version of eclipse/che that didn't support multiple LS on a single file. That problem has been solved and merged on eclipse/che and will be fixed on rhche with #200

Said that Bayesian LS is working fine on OSIO for a package.json file:

cc @invincibleJai @samuzzal-choudhury

[invincibleJai]

thanks @l0rd @mlabuda for putting more light on it. I tested requirements.txt as well , it's working as expected.

[krishnapaparaju]

@l0rd @invincibleJai thanks

[davidfestal]

Created PR https://github.com/redhat-developer/rh-che/pull/223. let's wait for the merge and promotion to prod before closing the issue.

[invincibleJai]

@davidfestal Thanks, now bayesian LSP is working with CHE for pom.xml tested in osio
(with Image: rhche/che-server:8c76cd6-fabric8-4d2c60e)

However one observation is earlier we need to edit once to see CVE's flagging on pom.xml. Issue for same ( https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/issues/13 ),
now i observed needed to edit more than once(there are some flickering notifications as well like "loading content"). This behaviour is only there for pom.xml and not for package.json or requirements.txt. I'll be looking into this , do let me know if you have any idea about this.

cc @samuzzal-choudhury

[davidfestal]

do let me know if you have any idea about this

I don't have any idea for now on this one. Maybe @tsmaeder might have some idea: he worked on multi-LS support.

However don't you think we should open a new issue for this other problem, and close this one ?

[l0rd]

This seams still related to #101 and may be fixed in bayesian LS (https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/issues/13). @tsmaeder @msrb can you please confirm?

[invincibleJai]

@davidfestal sure we can close this one. @l0rd it's not fixed in bayesian LS , i'll look into this and update as i was unable to see this behaviour on local minishift instance earlier will take latest and check.

[l0rd]

@davidfestal @invincibleJai Let's keep this open until fabric8-analytics/fabric8-analytics-lsp-server#13 is fixed and we have verified that pom.xml recommendations work fine.

[l0rd]

Closing this one since it's fixed Che side.