Revolution: MODX3 Can't log in unless I'm a sudo user

[SnowCreative]

Bug report

Summary

Can't log in unless I'm a sudo user.

Step to reproduce

Install MODX 3 alpha 3 nightly March 23. Assign your user Administrator permissions, super user. Uncheck "sudo" and save.

Observed behavior

You'll get logged out, and can't log in again. I've tried assigning other user groups and roles, and they all fail unless sudo is checked off.

Expected behavior

Should log in! I hadn't tested this with previous versions of alpha 3, so I don't know if this is new.

Environment

MODX 3 alpha 3 20210323

[sergant210]

1. I created a test user without the sudo permission.
2. Added him to the Administrator group with the "Super user" role.
3. Logged in to the manager successfully.

Did I do everything right?

[SnowCreative]

1. I created a test user without the sudo permission.
2. Added him to the Administrator group with the "Super user" role.
3. Logged in to the manager successfully.

Did I do everything right?

Did you use the latest nightly from March 23?

[sergant210]

I just tested on the latest dev 3.x branch. It works as expected.

[Ibochkarev]

Checked on a build installed today using a composer (3.x-dev 0acc0d92fcea3fc97ab5692a8d3b55648fd6ef2c)

https://user-images.githubusercontent.com/2138260/112715700-1767f300-8f0c-11eb-861c-18cf3916c2d8.mov

[sergant210]

Did you install from the 3.x branch or as usual?

[Ibochkarev]

Did you install from the 3.x branch or as usual?

composer create-project modx/revolution www 3.x-dev

[sergant210]

Confirmed.

[sergant210]

It seems to me that no one has tested permissions in MODX3. They don't work at all.

[Ibochkarev]

It seems to me that no one has tested permissions in MODX3. They don't work at all.

This is an alarming signal.

[sottwell]

Updated from github 31 March
Created user in Administrator group, not sudo user.

[sottwell]

Aside from the obvious access denied, there is the question of the "welcome back" when this is a new user's first attempt to log in.

[sergant210]

@sottwell I found out the reason - the permissions do not work. For sudo users the permissions are not checked.

[sottwell]

Yes, I just thought the screenshot and the conditions of my test would help clarify the situation.

[sottwell]

I thought someone had been using MODX 3 for some time in a production environment? Did they never use the permission system, or has their customized version solved the issue for their purpose?

[sergant210]

I mean that permissions don't work for all contexts and access targets.

[sergant210]

I thought someone had been using MODX 3 for some time in a production environment?

I think that there are no such crazy people.

[sottwell]

They were in a discussion on Slack some time ago, unfortunately that means no history and I don't remember the agency's name... there was mention made of their agency returning their modifications to the community.

[Mark-H]

Sterc has been using their fork in production, but technically that's closer to 2.x than 3.x. Or 2.x with a 3.x skin. ;)

I also have a dummy site on 3.x live on alpha1 I believe but that serves nothing of any importance.

There was a "fixing permissions" PR before the SnowUp, will see if I can find that when I'm in the office, could be related.

[Ibochkarev]

There was a "fixing permissions" PR before the SnowUp, will see if I can find that when I'm in the office, could be related.

https://github.com/modxcms/revolution/pull/15482 - I think you mean this one. There were no others as far as my memory serves

[Mark-H]

Nope, little older than that. It was this issue that should've been resolved with #15394

[SnowCreative]

Still not working in latest nightly (March 31).

[sergant210]

Not so fast. The workflow is next

1. Bug needs to be fixed (done).
2. It needs to be tested (in progress).
3. To create a PR and push it to the repository.
4. To wait a few months for the merging.

So be patient ;))

[opengeek]

• Bug needs to be fixed (done).
• It needs to be tested (in progress).

This is not true. This issue has not identified a specific bug that has been fixed, yet. Nor is anyone working on it that I know of. Please correct me if I'm wrong.

• To wait a few months for the merging.

Can we PLEASE stop with the sarcasm? It is counter-productive at the very least.

[sergant210]

This is not true. This issue has not identified a specific bug that has been fixed, yet.

This is not true. I've identified the problem, fixed it and I'll test it as soon as I can.

Nor is anyone working on it that I know of. Please correct me if I'm wrong.

You are wrong. Look at the assignees above.

Can we PLEASE stop with the sarcasm? It is counter-productive at the very least.

A sense of humor very often saves us from depression. I think we could all use a little smile ;)

[opengeek]

This is not true. This issue has not identified a specific bug that has been fixed, yet.

This is not true. I've identified the problem, fixed it and I'll test it as soon as I can.

Nor is anyone working on it that I know of. Please correct me if I'm wrong.

You are whrong. See the assignees above.

Thank you for clarifying. I did not read any comments saying the problem had been identified or that you were working on a solution. Assigning yourself the issue does not tell me anything specific.

Can we PLEASE stop with the sarcasm? It is counter-productive at the very least.

A sense of humor very often saves us from depression. I think we could all use a little smile.

I agree. Humor is very important. But this particular comment and other similar comments coming from people that are supposed to be working together to increase the pace of integration on this project are debatably funny and can easily be misinterpreted by those that have been responsible for integration. It has been made clear over and over how everyone feels about the pace of integration. There is no need to amplify that. We can make different jokes and work together to solve the contribution issues.

[Ibochkarev]

Fixed #15632