Revolution: Form Customization Tab Rank not saving or random number after editing. Bug?

Created on 27 Jan 2015  路  7Comments  路  Source: modxcms/revolution

When editing a "Form Customization" set and modifying a "Region Rank" from the column after saving everything looks fine.
After reloading the page or re-opening the set the changed values are back to default or even random numbers.

MODX version 2.3.2-pl

Is this a bug?
Can anyone confirm the same problem?
Is there a workaround?
http://forums.modx.com/thread/95943/form-customization-tab-rang-not-saving-or-random-number-after-editing-bug#dis-post-519292

bug area-fc

All 7 comments

Confirmed for modx 2.5.5 region rank is not saved.

After reloading the form customization all values are set to 0.

I guess the problem is located here:

https://github.com/modxcms/revolution/blob/2.x/core/model/modx/processors/security/forms/set/update.class.php

As far as I understand rank is only saved if region is not "modx-panel-resource-tv". It should be modified by +20 then but for unknown reasons its only +10 in the end).

I'm confused...

Oh, I get it. Everytime a FC is saved, the value of rank is modified by -10. Until the value is 0 or less at which moment the value is permanently set to 0.

So far I also haven't found a single line of code that effects how tvs are ranked in "modx-panel-resource-tv".

modxbughunt I've confirmed this problem a few days ago on different MODX instance. Today I had slightly different results.

  • If a Tv is not relocated, then the rank is 0 after saving the customisation form.
  • If a TV is relocated it the rank rises by 10 every time I save the form.

Initial values (random numbers for the first group which stays on the TV tab), incremental numbers for the second group.

Initial Values:
screenshot 2017-03-03 19 53 12

After saving:
screenshot 2017-03-03 19 53 38

Saving again:
screenshot 2017-03-03 19 53 57

This makes it impossible to change the order of appearance on the TV tab. For relocated tabs, the rank is constantly rising which is very annoying.

Same here with 2.5.4 and 2.5.5.

Still an issue in 2.7.0. Region Rank is not saved.

I researched code, and consclusion:
image
(core\model\modx\processors\security\forms\set\update.class.php)

~ 289 line (modx 3.x branch)

=>
if you dont change region from modx-panel-resource-tv, you cannot set order for this tv, because result - tvs disappearing from everywhere from the page (i manually change condition if (!empty($tvData['tab']) && $tvData['tab'] != 'modx-panel-resource-tv') and remove 'modx-panel-resource-tv' from it

=> this is not a bug, it is made specially

Was this page helpful?
0 / 5 - 0 ratings