Revolution: Svg support for image TV preview

[labr1005]

Summary

The image TV preview does not support svg.

Step to reproduce

Add "svg" to the system setting "upload_images" and your media source's "imageExtensions" setting.
Upload and choose a svg in your image TV.

Observed behavior

The image TV preview does not show (a preview of) the svg.

Expected behavior

The image TV preview should show (a preview of) the svg.

Environment

MODX 2.5.8-dev
Apache/2.2.29 (Unix)
PHP 7.0.8

[OptimusCrime]

Not sure if I understand? Did you create this because no issue was posted about SVG preview in the manager? Or did the PR not work?

[labr1005]

The referenced PR only fixes SVG support in the MODX Browser and the Files Tree - not for image TVs. If the PR gets accepted, this could/should/will be a new issue.

[labr1005]

But I guess I got something wrong about referencing PRs and issues...

[OptimusCrime]

Ah, okey. That is fine. This should be there then, as this is separate. Good work :)

[JoshuaLuckers]

The Image TV uses phpthumb for the preview thumbnails as can be seen here:
https://github.com/modxcms/revolution/blob/21c52bc479282964201a27123277decd62c7174c/manager/templates/default/element/tv/renders/input/image.tpl#L3
and
https://github.com/modxcms/revolution/blob/21c52bc479282964201a27123277decd62c7174c/manager/templates/default/element/tv/renders/input/image.tpl#L51

The SVG preview in, for example, the tree is handled differently:
https://github.com/modxcms/revolution/blob/21c52bc479282964201a27123277decd62c7174c/core/model/modx/sources/modfilemediasource.class.php#L236-L251