Revolution: Moving directories up/down adds dir as a subdirectory

[sdrenth]

Summary

When moving directory up/down inside the files tree, the directory gets moved inside the directory directly below it after dragging the folder.

Step to reproduce

• Go to the Files tab inside the MODX manager
• Create directories:
  
  
  
  • Test 1
  
  
  • Test 2
  
  
  • Test 3
  
  
• Move Test 2 above Test 1
• Refresh the tree

Observed behavior

Instead of moving the directory "Test 2" above "Test 1", the directory is now added as a child directory to "Test 1".

Expected behavior

I expected that after moving a directory above Test 1, that the directory Test 2 is shown above Test 1, and is not added as a subdirectory.

Environment

• MODX Version: Modx Revolution 2.5.1-PL (Clean install from traditional installation package)
• Google Chrome 54.0.2840.71 (64-bit)
• Nginx

[EasterPeanut]

Also noticed similar unexpected behavior of the file tree in the Media Browser when dragging files.

1. Go to the Media Browser
2. Drag a file from inside a directory to the root, between two other directories

Now sometimes the file will be placed in the directory right underneath the divider line and sometimes it's placed in the root. So it's not consistently going wrong.

The right behavior seems to be the latter: if you place a file between two directories, in the root, it should go there. To the root.

MODX 2.5.2, Google Chrome 55.0.2883.95 (64-bit), Nginx

[labr1005]

I'll try to fix this today.

[labr1005]

@sdrenth @EasterPeanut

IMO sorting of directories or files should not be possible at all. Why would you want to do this? They should always be sorted alphabetically.

It should only be possible to drag directories/files inside other directories.

[sdrenth]

@labr1005 @EasterPeanut I don't think it is necessary to sort directories/files, but the problem is that the UI makes it look like it can. And as I described above, the directory is then being moved inside the other directory instead of being moved above it.

[Mark-H]

Fixed in 2.5.6