Revery: Style is missing flexWrap

[nikgraf]

If I understand correctly you using Yoga under the hood and it already supports flexWrap: https://yogalayout.com/docs/flex-wrap/

Is there a reason why it's not supported or is this an easy addition? Happy to open a PR: https://github.com/revery-ui/revery/blob/master/src/UI/Style.re#L35-L38

[wokalski]

Afaik this library depends on Jordan Walke's Flex. https://github.com/jordwalke/flex

[nikgraf]

Yeah, he supports it too: https://github.com/jordwalke/flex/blob/12d61f54aca648ecf4c546551964b3c633c7cc9a/src/lib/LayoutTypes.re#L76

[bryphe]

Thanks for the issue, @nikgraf !

Yes, we are still missing some of the style properties supported by the flex library - a PR to add flexWrap would be great 👍

[czystyl]

@nikgraf Let me know if you will be doing this one; if not, I'll like to help with this one and start contributing here 💪

[nikgraf]

@czystyl justed did one here, but you could check if others are missing as well

[czystyl]

@bryphe I see that these props are missing from :

• [ ] marginStart
• [ ] marginEnd
• [ ] minWidth
• [ ] minHeight
• [ ] maxWidth
• [ ] maxHeight

I don't know the codebase well but couldn't find these options in the codebase. Let me know if Revery should handle that case as well.

[bryphe]

@czystyl - good catch! Yes, the flex library we're using supports those - we should expose those too in our style props and pass them through for the layout engine. Would be great to have those as well. 👍