Retrofit: SimpleXmlConverterFactory deprecated without replacement for Android

Created on 16 Apr 2018 · 4Comments · Source: square/retrofit

I just noticed after upgrading to 2.4 on my Android project that the SimpleXmlConverterFactory is now deprecated and it suggests using JAXB while on the JAXBConverter page it says it does not support Android. This means, that there is now no "supported" XML converter for Android.
I would suggest rethinking the deprecation of the SimpleXmlConverterFactory.

Source

hameno

Most helpful comment

Deprecated doesn't mean non-functional. You're free to continue using it.

It was deprecated because Simple XML is a dead library with CVEs. If you'd like an alternative that works on Android consider https://github.com/Tickaroo/tikxml.

JakeWharton on 16 Apr 2018

👍14 👎1

All 4 comments

Deprecated doesn't mean non-functional. You're free to continue using it.

It was deprecated because Simple XML is a dead library with CVEs. If you'd like an alternative that works on Android consider https://github.com/Tickaroo/tikxml.

JakeWharton on 16 Apr 2018

👍14 👎1

Good to know, will look into switching. Thanks :)

hameno on 16 Apr 2018

Is there any example implementation for Tickaroo In android. We followed their documentation, but we end up in a issue saying "No TypeAdapter found" on using it with retrofit.

VikiVignesh026 on 12 Jul 2018

@VikiVignesh026
Does your pojo has inner class? I also encountered "No TypeAdapter found" when trying TikXml, then I found TikXml's AutoValueTypeAdapterCodeGenerator didn't handle inner class well. After I change inner classes to separate classes, TikXml works well for me.

Following is my code adding tikXmlConverterFactory into Retrofit.Builder.

new Retrofit.Builder()
.addConverterFactory(tikXmlConverterFactory)
.addCallAdapterFactory(rxJava2CallAdapterFactory)
.client(okHttpClientForXml)
.baseUrl(baseUrl)
.build();

https://github.com/lukechi1219/HelloDagger/blob/master/app/src/main/java/com/lukechi/android/hellodagger/factory/CustomRetrofitFactory.java