Retrofit: Support for RxJava 1.2

[cosminstefanxp]

Recently, RxJava 1.2.0 has been released and they've made some backward-incompatible changes related to Completables, specifically:

• CompletableSubscriber -> rx.CompletableSubscriber
• CompletableOnSubscribe -> rx.Completable.OnSubscribe

After upgrading to it, I'm getting the following gradle build issues related to Retrofit:

Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallOnSubscribe: can't find superclass or interface rx.Completable$CompletableOnSubscribe
Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallAdapter: can't find referenced method 'rx.Completable create(rx.Completable$CompletableOnSubscribe)' in program class rx.Completable
Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallAdapter: can't find referenced class rx.Completable$CompletableOnSubscribe
Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallOnSubscribe: can't find referenced class rx.Completable$CompletableSubscriber
Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallOnSubscribe: can't find referenced class rx.Completable$CompletableOnSubscribe
Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallOnSubscribe: can't find referenced class rx.Completable$CompletableSubscriber
Warning:retrofit2.adapter.rxjava.CompletableHelper$CompletableCallOnSubscribe$1: can't find referenced class rx.Completable$CompletableSubscriber

[vanniktech]

2024

[cosminstefanxp]

Great, thanks. Any info re. when it will be included in a release?

[JakeWharton]

It will be in the next release but no there's no timeframe. "Soon" is the
best we have. You can use the snapshot for now.

On Thu, Sep 29, 2016, 8:05 AM Cosmin Stefan-Dobrin [email protected]
wrote:

Great, thanks. Any info re. when it will be included in a release?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/retrofit/issues/2034#issuecomment-250447698,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEdxZHXSujdFV7Xq2_dG6vxRUxDuCks5qu6mXgaJpZM4KJ435
.

[JakeWharton]

Those warnings are safe to ignore.

[cosminstefanxp]

Thanks! 👍

[Pitel]

How to ignore them? I added -dontwarn rx.Completable.** to my ProGuard rules, but I still get these warnings.

[JakeWharton]

Suppress the Retrofit class, not the Rx class.

On Tue, Oct 4, 2016, 2:09 PM Ing. Jan Kaláb [email protected]
wrote:

How to ignore them? I added -dontwarn rx.Completable.** to my ProGuard
rules, but I still get these warnings.

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/square/retrofit/issues/2034#issuecomment-251370040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEVvYag31PpJ2fH_-CcYC-PQpTgn4ks5qwkHsgaJpZM4KJ435
.

[Pitel]

-dontwarn rx.Completable** (no dot!)

[PaulWoitaschek]

It would be great to have a release soon. My app just failed with a runtime crash because one of my dependencies updated its RxJava. So I had to spend some time figuring out how to resolve this.

configurations.all {
    resolutionStrategy.force "io.reactivex:rxjava:$vRxJava"
}

[baudm]

As per Jake's comment, the ProGuard rule should be:
-dontwarn retrofit2.adapter.rxjava.CompletableHelper$**