Resque: Airbrake handler calls .notify_or_ignore, which was removed from the airbrake gem

Created on 11 Mar 2016  路  7Comments  路  Source: resque/resque

This code calls Airbrake.notify_or_ignore, which was removed in the 5.x versions of the Airbrake gem, in favor of simply Airbrake.notify.

Bug

All 7 comments

We've been wanting to remove the airbrake integration and make it a separate gem anyway.

@steveklabnik I'm glad to help here, as I have the same issue.
Would you prefer a PR fixing this (to account for both cases) or to create a separate gem now?

Whichever works for you, frankly. Thanks so much for offering to pitch in!

Oh, actually the new airbrake already seems to provide this: https://github.com/airbrake/airbrake/blob/master/lib/airbrake/resque/failure.rb

The tricky part, I guess, is how to tell your app to require that one and not the one provided by resque when you have airbrake >= 5.

Oh, spoke too soon. It's actually documented: https://github.com/airbrake/airbrake/blob/master/docs/Migration_guide_from_v4_to_v5.md#resque

I think that solves the issue, without doing anything :)
@seanwalbran does that work for you?

Looks like it, thanks!

Oh rad, even better :)

The tricky part, I guess, is how to tell your app to require that one and not the one provided by resque when you have airbrake >= 5.

I was planning on saying "This release removes airbrake support, but please drop in this gem and it will work". So if it's functionally equivalent, we can just do that.

Was this page helpful?
0 / 5 - 0 ratings