Respec: Suggest removal of redundant config options

Created on 5 Feb 2019  路  13Comments  路  Source: w3c/respec

Important info

Description of problem

ReSpec users generally copy/paste the "respecConfig". What would be nice is that for config values that are already on by default (in core/default or w3c/default), ReSpec should warn that those should be removed from the configuration.

This depends on :
https://github.com/w3c/respec/pull/2042

good first issue

Most helpful comment

Yeah, maybe it should be an optional thing. In the Payments spec, I鈥檓 unsure what I can remove from the config and I鈥檓 too lazy to see what鈥檚 on by default. So would appreciate if ReSpec told me.

All 13 comments

Is that behavior generally preferred? I think explicit values ensures that the local settings would never be affected by upstream changes.

Yeah, maybe it should be an optional thing. In the Payments spec, I鈥檓 unsure what I can remove from the config and I鈥檓 too lazy to see what鈥檚 on by default. So would appreciate if ReSpec told me.

@marcoscaceres Can I work on this issue? I'm new to respec

Heh, good recovery (pdf.js 馃憖馃榿). Sure, please get set up by reading the developer guide - link is in the README.

Hey. Can I work on this ?

Is there any issues which not yet get assigned. Please tell about that I want to get assigned.

@gaurav3210, you are free to grab any claimed issue that hasn't been completed after a week.

Thank you sir.

Will you please assigned this issue to me. I will PR by tomorrow

@gaurav3210 please see the good first issues list. If you are interested in GSoC, having self initiative is a prerequisite.

ReSpec should warn that those should be removed from the configuration.

I am so confused about this feature. In my opinion, instead of warning user that those duplicated configurations should be removed, we can introduce the concept of configuration priority. In this way, core/defaults with higher priority can overwrite w3c/defaults with a lower priority so that ReSpec can automatically these handle configuration conflicts instead of bothering users.

@marcoscaceres, please let me know whether I should work on this idea. Thanks!

Sorry for possibly misunderstanding what you mean:

ReSpec users generally copy/paste the "respecConfig". What would be nice is that for config values that are already on by default (in core/default or w3c/default), ReSpec should warn that those should be removed from the configuration.

Are you mean that we should warn users that which configrations were turned on by default?

Are you mean that we should warn users that which configrations were turned on by default?

Yes... but I'm having second thoughts. Reflecting on the previous discussions, I think it's fine to just leave them.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

saschanaz picture saschanaz  路  5Comments

xfq picture xfq  路  4Comments

andrea-perego picture andrea-perego  路  3Comments

marcoscaceres picture marcoscaceres  路  3Comments

marcoscaceres picture marcoscaceres  路  6Comments