Respec: (refactor): Remove jQuery from ReSpec

Created on 4 Oct 2018  ·  23Comments  ·  Source: w3c/respec

Remove jQuery from following remaining modules:

  • [x] core/requirements https://github.com/w3c/respec/pull/1845
  • [x] [core/figures](https://github.com/w3c/respec/blob/develop/src/core/figures.js) https://github.com/w3c/respec/pull/1956
  • [x] [core/structure](https://github.com/w3c/respec/blob/develop/src/core/structure.js) https://github.com/w3c/respec/pull/1957
  • [x] [core/link-to-dfn](https://github.com/w3c/respec/blob/develop/src/core/link-to-dfn.js) #1897
  • [x] [core/dfn](https://github.com/w3c/respec/blob/develop/src/core/dfn.js) #1898
  • [x] [core/ui](https://github.com/w3c/respec/blob/develop/src/core/ui.js) #1930
  • [x] [core/issue-notes](https://github.com/w3c/respec/blob/develop/src/core/issues-notes.js) #1969
  • [x] [w3c/conformance](https://github.com/w3c/respec/blob/develop/src/w3c/conformance.js) #1926
  • [x] tests: ~core/dfn-spec.js~, ~core/informative-spec.js~, ~core/issues-notes-spec.js~, ~core/section-refs-spec.js~, ~core/structure-spec.js~, ~core/utils-spec.js~, ~w3c/conformance-spec.js~, ~w3c/headers-spec.js~ (https://github.com/w3c/respec/pull/1977, https://github.com/w3c/respec/pull/1979)
good first issue refactoring

Most helpful comment

Maybe we should leave those for interns? We have a few other high priority things that I'd really like for use to work together on: ✨ https://github.com/w3c/respec/issues/1804

All 23 comments

Doing some of the quick ones (figures, structure, conformance) in remove-jquery branch.

Update: Leaving them for others. Keeping that branch for anyone who wants to use the work already done in it.

Maybe we should leave those for interns? We have a few other high priority things that I'd really like for use to work together on: ✨ https://github.com/w3c/respec/issues/1804

Hi @sidvishnoi @marcoscaceres i would like to work on it m can you help me getting started for this repository?

Thanks

Hi @akansha2608, check out tge developer’s guide:
https://github.com/w3c/respec/wiki/Developers-Guide

I’ll try to find you on Monday and give you some tips. But have a play and have a look around the wiki too.

Hi, @marcoscaceres @sidvishnoi can I work on this one?

Sure! Feel free to take any of the above.

@akansha2608 and @treyhboy Which ones are you guys working on? Wanna take a stab at it too.

@anoited007, please feel free to grab any of them.

@marcoscaceres Sorry I missed ur follow up. I will get to work then.

Can I work on this issue if it is not already in progress?

Hi! Looks like now only core/issue-notes remains.
@saschanaz are you going to leave this one for the rest of us? 😂

@sidvishnoi Alright, actually when I saw this only 5/8 were marked complete. I will look at some other issue.

@Swapnilr1 easy one https://github.com/w3c/respec/issues/1959 (remove some dead code)

@Swapnilr1 you can also search "src/" for "$(" to see if there are any other jQuery things we missed.

@marcoscaceres Thanks. I am working on #1762 at the moment. And then I will work on this, if not already done by then.

Hi, I am taking up the last one if that's fine.

I've added tests in list above. So, someone can do them also.

Can I also take the tests up as well? I have never written tests before (just debugged), excited to learn! :sweat_smile:

@sidvishnoi Is there anything left that I can work on in this issue?

@yatri1609 Unfortunately, there isn't anything left in this issue. We can use your help at other issues like https://github.com/w3c/respec/issues/1950, https://github.com/w3c/respec/issues/1713, https://github.com/w3c/respec/issues/1631, https://github.com/w3c/respec/issues/1239

I think with #1979, we are jQuery free 🎉🤞?

Confirmed we have no more $().

We're jQuery free but we're still shipping jQuery for backward compatibility.
I believe you two were waiting on me to close this issue? Thanks 😄 ❤️

Was this page helpful?
0 / 5 - 0 ratings

Related issues

noamr picture noamr  ·  3Comments

sidvishnoi picture sidvishnoi  ·  4Comments

andrea-perego picture andrea-perego  ·  3Comments

saschanaz picture saschanaz  ·  3Comments

marcoscaceres picture marcoscaceres  ·  6Comments