Respec: Improve github labels

Created on 21 Mar 2018  路  9Comments  路  Source: w3c/respec

Github labels are showing up, and they are awesome. Some improvements we could make:

  • [x] cache issues (critical - we only get 60 requests / hour on Github)
  • [x] concurrent download of issues (critical). The current design awaits each issue.
  • [ ] wrap them in an unordered list (<ul>).
  • [x] add an aria label, so this reads: "This issue is labelled on github as: x, y, and z".
  • [x] remove or improve hover effect... currently it's getting inherited, and it's a little bit too much.

cc @himanish-star

good first issue

All 9 comments

remove or improve hover effect... currently it's getting inherited, and it's a little bit too much.

Yep. This kills the design of the labels

We hit a couple of unexpected issues with the last release of this feature (49463aa89b6c8eb45f17d0a08e28b567c3ec5d6e). Mainly to do with the changes we made for fetching and github API limits.

@himanish-star this might also be a good one if you want to get back into things. This feature is really awesome, so would be great to build on it a bit more.

Hey @marcoscaceres!!!!, sure I would love to work on this. But, as I am pretty much occupied with some other work, I think I'll be only able to work on this in the weekends. Will that work for you?
I could start off with this from the coming weekend :)

oh, whenever you can. No stress! If you don't get time, that's also fine. Just let me know.

I would like to try this one as my next issue, if no one is currently working on this.

Reopening as there are more items in checklist

@sidvishnoi I would like to work on it. Can you please brief me on what is to be done?

Talked with @himanish-star... we decided not to wrap the labels in UL. It appears that caching was done at some point.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

deniak picture deniak  路  5Comments

marcoscaceres picture marcoscaceres  路  4Comments

xfq picture xfq  路  4Comments

marcoscaceres picture marcoscaceres  路  6Comments

saschanaz picture saschanaz  路  6Comments