Respec: Show labels from github

Created on 31 Mar 2016  路  11Comments  路  Source: w3c/respec

For issues included from github, it might be nice to also include the labels.

enhancement

All 11 comments

What do you mean by this, @marcoscaceres?

This is for when people include issues from github into specs:

<div class="issue" data-number="123">
</div>

The above gets filled with content from github. My idea as to also show any labels associated with the issue.

I mean to cause no inconvenience to anyone by commenting in a number of issues. But I also have a working solution for this issue too! I will also reference my commit here in a while. But I will wait until I'm done with PRs #1477 and #1473 before filing a PR for this issue :smiley:

EDIT: This is how it looks and this is where you can find the code change https://github.com/himanish-star/respec/commit/f76716e5315f5ca16cac956f8e1dd85a82c669a1

image

@himanish-star, no need for apologies. Please feel free to comment or ask anything. Your help is greatly appreciated.

Looking really great, @himanish-star!

Thanks marcos :smiley:

@himanish-star, good job!

If I may, :+1: to your suggestion, but :-1: to capitalising all labels automatically (I see that labels in the issues you're using for testing are not all in caps themselves: #1369; #1370). Sometimes labels include CamelCase words, acronyms, etc, and that would be lost when capitalising all. ALSO, CAPS REDUCE READABILITY, imho.

Yeah, might be best to leave the capitalization as is. Well spotted @tripu!

Sure I'll see to this

image

I have made changes but I have some tests failing so I'm looking into that. @tripu are you happy with the changes

@himanish-star, yes, thank you!

(I would suggest perhaps more space between the title of the issue and the set of labels, but we can fine-tune those things once you have a PR ready for review.)

Yeah I have still one more test failing which I'm trying to correct

Was this page helpful?
0 / 5 - 0 ratings

Related issues

marcoscaceres picture marcoscaceres  路  5Comments

saschanaz picture saschanaz  路  5Comments

marcoscaceres picture marcoscaceres  路  4Comments

saschanaz picture saschanaz  路  6Comments

saschanaz picture saschanaz  路  6Comments