Rescript-compiler: bsb -make-world doesn’t work with spaces in pathnames

[rauschma]

I’m getting errors if I clone the following repo into iCloud Drive and build it: https://github.com/rauschma/reasonml-demo-modules

For example:

[1/17] Building src/Log.mliast
FAILED: src/Log.mliast 
/Users/rauschma/Library/Mobile Documents/com~apple~CloudDocs/_Code/_reasonml/reasonml-demo-modules/node_modules/bs-platform/lib/bsc.exe -pp "/Users/rauschma/Library/Mobile Documents/com~apple~CloudDocs/_Code/_reasonml/reasonml-demo-modules/node_modules/bs-platform/lib/refmt3.exe --print binary"   -w -30-40+6+7+27+32..39+44+45+101 -bs-suffix -nostdlib -I '/Users/rauschma/Library/Mobile Documents/com~apple~CloudDocs/_Code/_reasonml/reasonml-demo-modules/node_modules/bs-platform/lib/ocaml' -no-alias-deps -color always  -c -o src/Log.mliast -bs-syntax-only -bs-binary-ast -intf '/Users/rauschma/Library/Mobile Documents/com~apple~CloudDocs/_Code/_reasonml/reasonml-demo-modules/src/Log.rei'
/bin/sh: /Users/rauschma/Library/Mobile: No such file or directory

The errors go away if I move the repo into a directory whose path doesn’t have spaces in them.

[bobzhang]

@rauschma is Mobile Documents created by you or Apple?

[rauschma]

@bobzhang That’s where Apple’s iCloud Drive is always located (I prefer how Dropbox solves this problem).

But spaces are generally common on macOS (“John’s SSD” etc.).

[digitake]

This is annoying. Please fix or can anyone point out how can I do my quick fix?

[Nanonid]

How can a "show stopper" unable to use with a space in path name be a "non-critical-bug"?
Broken on windows for %APPDATA% user home containing a space.
These growing pains convinces me to pass on Reason for production projects.

[NEUDitao]

I was also affected by this on my first few attempts to get Reason up and working

[ulrikstrid]

Also have this issue on Windows. I can only run .exe from "Program Files" because of policy at work so this is blocking me badly as I can't even build the project.

I think we need to put quotes somewhere to fix this, if I can get pointers on where and I can do the work.

[bobzhang]

@ulrikstrid we will prioritize this issue

[ulrikstrid]

@bobzhang I managed to get a policy change to put it in another folder and got unblocked. I'm still willing to do the work if I can just get some pointers on where to do the changes.

[bobzhang]

@ulrikstrid thanks for the offer. Mostly I need test it on Windows machine and look at the generated build.ninja. The relevant source code would be in jscomp/bsb directory

[bobzhang]

For the record, there are some serious issues in the combination of a whitespace and an extra flag under Windows:

-pp "/Users/rauschma/Library/Mobile Documents/com~apple~CloudDocs/_Code/node_modules/bs-platform/lib/refmt3.exe --print binary" 

Will wait to see if we can get some convenience from reason upstream

[kachel]

I just ran into this issue today (macOS).

[peacememories]

Same here, I use ~/Library/Application\ Support/ as a parent directory for my scratch projects, and when running bucklescript (or just the vscode extension) it fails and generates a ~/Library/Application\%20Support directory

[bobzhang]

@peacememories @kachel can you share with more details, I tested on Application support and it works good for me (at least for BuckleScript), not sure about the vscode extension

[peacememories]

Hmm, bsb itself indeed seems to work. The problems I've run into are with the VSCode addon and with Parceljs.

[bobzhang]

@peacememories thanks for the confirmation