As part of #159, there's a symlink now in the test suite, since postBuild scripts for both the memorylimit tests are the same. However, this seems to break shutil on alpine. There's more discussion here: https://github.com/docker-library/python/issues/155 and https://github.com/python/cpython/pull/4267. Most likely because of musl vs libc issues.
This breaks the 'deploy' step, since our docker image no longer builds.
To get deploys working again I'd propose to duplicate the postBuild script. Once we have this deployed and are happy with the memlimiting we can take our time to decide if we want to change based image or what.
I agree! am working on a PR now.
@yuvipanda Does #161 close this?
It works around it for now, the underlying problem is still unfixed tho
On Dec 12, 2017 7:03 PM, "Carol Willing" notifications@github.com wrote:
@yuvipanda https://github.com/yuvipanda Does #161
https://github.com/jupyter/repo2docker/pull/161 close this?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/repo2docker/issues/160#issuecomment-351267867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23pFhSusChuxEoNaUKmqpDY87dV6Tks5s_z6DgaJpZM4QyBUL
.
We moved away from alpine linux completely in 379c52bac3ab796cd945b3457295b3b4c3f9c6b6, so we can close this now.
Most helpful comment
It works around it for now, the underlying problem is still unfixed tho
On Dec 12, 2017 7:03 PM, "Carol Willing" notifications@github.com wrote: