I was thinking we could add a minimal CODEOWNERS file to the repo. In particularly I thought it would be good to have @HonkingGoose as owner of docs/ so that they are automatically requested to review any non-draft PR that modifies docs.
However it could also be useful e.g. for @JamieMagee to be owner of lib/platform/azure/? Any others?
https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners
sounds good
Is it possible to assign all markdown files to @HonkingGoose ?
A CODEOWNERS file uses a pattern that follows the same rules used in gitignore files
Azure + git-submodules for me sounds good.
I think @ppmathis for Gitea is a good idea as well.
FYI I think users need to accept an invitation for us to be a collaborator before adding them to CODEOWNERS works, so I have invited @ppmathis (link). If anyone's reading this in future and wants to be a CODEOWNER of something they contributed, please ping us to invite you to be a collaborator so we can do so.
@JamieMagee Sounds good to me, I'm happy to be a code owner for the Gitea platform.
@rarkins Thank you for the invite, I just accepted it.
Hi @rarkins,
I'm willing to do _some_ review work for the docs, but I can not dedicate a lot of time to this right now.
I can't promise a quick and speedy review each and every time.
What are your expectations for review response? I worry that I might be slowing down PRs unnecessarily by not always responding on time?
CODEOWNER reviews aren't mandatory - it's just about automating the "add reviewer" step. Totally fine if you can't keep up
Oh in that case, it's fine to add me to the CODEOWNERS file for docs changes. 馃憤
Nice to know that I'm not required to review all the things. 馃槍
@HonkingGoose Assigning to you simply means we would happy if you can have a review, but no hurry or requirements. 馃槄
So if i assign you to review a pr i hope you can simply check the docs changes, so they are well speeched. I'm not a native english speaker, so my english language knowledge is limited. 馃槈
:tada: This issue has been resolved in version 23.94.0 :tada:
The release is available on:
23.94.0Your semantic-release bot :package::rocket:
Most helpful comment