Renovate: Feature Request: Support extended Docker configuration options in gitlabci managers

Created on 3 Jul 2020  路  2Comments  路  Source: renovatebot/renovate

What would you like Renovate to be able to do?
Renovate doesn't pick up our GitLab CI Services that use the extended syntax, for example:

ui-test:
  stage: test
  services:
    - name: internal.docker.hub.company/selenium/standalone-firefox:3.141.59-xenon
      alias: standalone-firefox
    - name: internal.docker.hub.company/selenium/standalone-chrome:3.141.59-xenon
      alias: standalone-chrome

Describe the solution you'd like
Renovate should be able to parse this syntax. I debugged it and found out the whole parsing is done using regular expressions (instead of a YAML parser) and the regex simply doesn't support this format (and many of other syntactically valid variations).

Describe alternatives you've considered
Maybe we can switch to the simplified syntax and use the longer hostnames to access the services, avoiding extended options and not needing the additional support. I'm not sure if/how the 64/255 character-limit for hostname applies to docker services, though.

gitlab-ci bug

Most helpful comment

Recommendation: let's combine gitlabci and gitlabci-includes managers into one (gitlabci) and use YAML parsing. After that, we fix this problem.

All 2 comments

We actually should be able to switch to plain YAML parsing now. The regex-based approach was done in the days when we needed to be able to pinpoint the exact line, but that is no longer necessary.

Recommendation: let's combine gitlabci and gitlabci-includes managers into one (gitlabci) and use YAML parsing. After that, we fix this problem.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jycouet picture jycouet  路  4Comments

zephraph picture zephraph  路  3Comments

hutson picture hutson  路  3Comments

jgarec picture jgarec  路  3Comments

OmgImAlexis picture OmgImAlexis  路  4Comments