Renovate: Upgrade got to v11

Created on 29 May 2020  路  8Comments  路  Source: renovatebot/renovate

priority-2-important refactor

Most helpful comment

I think this one is unblocked now @viceice @zharinov @szmarczak

All 8 comments

I think this one is unblocked now @viceice @zharinov @szmarczak

The challenges of types for this is beyond me. Anyone able to step up?

I've found that the changes to get it working in a simple case are small: https://github.com/renovatebot/renovate/compare/refactor/got-11

Need help on the types though.

I can have a look at it tomorrow

I'm looking forward to seeing this upgrade happen. I'm getting regular errors with Unexpected end of JSON input (maybe 9 times out of 10) from bitbucket-server getPrList while running with latest renovate, on node 12.18.1, and from the looks of the discussion in https://github.com/sindresorhus/got/issues/1062 this upgrade should help somewhat with that. I'll note that the recent refactors around util/http have changed this error away from regularly being an ECONNRESET error, so that seems to be an improvement.

@viceice did you hit any obstacles with this?

Beside some test failures to look at, no.

Had no time to investigate further, maybe on Sunday afternoon. 馃様

:tada: This issue has been resolved in version 21.34.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings