Renovate: Include a link to Intrinsic's Package Diff in PRs

Created on 5 Mar 2019  路  9Comments  路  Source: renovatebot/renovate

What would you like Renovate to be able to do?
Include a link to Instrinsic's Package Diff in revision update PRs.

Describe the solution you'd like
I'd like to be able to easily and quickly see a package diff between the current version and the proposed version in the PR. Since NPM packages can be published without corresponding source updates, linking to the source repo is less reliable than doing a diff of the actual packages.

Describe alternatives you've considered
At the moment I build the links by hand, but it would be great to have it automated.

Additional context
Motivated by the recent release of [email protected], which had no corresponding github release and appeared to be a suspicious release.

npm priority-3-normal

All 9 comments

:tada: This issue has been resolved in version 14.38.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Thanks @rarkins!

This doesn't seem to work for a number of our packages.

https://diff.intrinsic.com/@financial-times/n-myft-ui/18.5.6/18.6.2

I've emailed Intrinsic with the feedback. Love the idea though!

Hopefully it's a small bug they can fix. Maybe a file exists in one but not the other or something like that.

Got an email back 馃帀

Samuel,

We fixed the bug you encountered:
https://diff.intrinsic.com/@financial-times/n-myft-ui/18.5.6/18.6.2

Your hunch was correct, it had to do with files within dot directories.

Thanks for the report,
Thomas Hunter II

I know they don't support major updates, so ideally we shouldn't link for those. For others, maybe they have a problem with their backend right now. For any "old" links like those in previous comments here, they all still work.

@leethree @rarkins we had a bug with our cache reaper which led to a full disk. It should be fixed now.

We did specifically disable major to major comparison (and minor to minor comparison where the minor difference is > 5). This was chosen because we assumed diffs would be massive and that Package Diff wouldn't be a good tool to visualize them. If Renovate needs such a feature we can remove the limitation.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jgarec picture jgarec  路  3Comments

rarkins picture rarkins  路  3Comments

hutson picture hutson  路  3Comments

zephraph picture zephraph  路  3Comments

kogai picture kogai  路  3Comments