Relay: expose RelayNetworkLogger as public API

Created on 3 Mar 2019  路  1Comment  路  Source: facebook/relay

related to this one https://github.com/facebook/relay/issues/1856

right now people are using like this:

import RelayNetworkLogger from 'relay-runtime/lib/RelayNetworkLogger'

example here https://github.com/mrtnzlml/meta/blob/master/relay.md#relaynetworklogger

We can recreate RelayNetworkLogger using exported apis of relay-runtime like this

import { createRelayNetworkLogger, RelayNetworkLoggerTransaction } from 'relay-runtime'

const RelayNetworkLogger = createRelayNetworkLogger(RelayNetworkLoggerTransaction);

based on this one https://github.com/facebook/relay/blob/master/packages/relay-runtime/network/RelayNetworkLogger.js#L17

however these exports are marked as INTERNAL-ONLY: https://github.com/facebook/relay/blob/master/packages/relay-runtime/index.js#L246

I think we should export RelayNetworkLogger and other 2 as public and "stable" APIs, and we should add documentation about it

Most helpful comment

use like this

import { createRelayNetworkLogger, RelayNetworkLoggerTransaction } from 'relay-runtime'

const RelayNetworkLogger = createRelayNetworkLogger(RelayNetworkLoggerTransaction);

>All comments

use like this

import { createRelayNetworkLogger, RelayNetworkLoggerTransaction } from 'relay-runtime'

const RelayNetworkLogger = createRelayNetworkLogger(RelayNetworkLoggerTransaction);
Was this page helpful?
0 / 5 - 0 ratings