Relay: [Modern] Paging fetches data but props are not updates

[luongthanhlam]

I cloned and run this repo https://github.com/AndreiCalazans/hackernews-react-relay because of a problem in another project I have that also involves a PaginationContainer nested inside a QueryRenderer. The problem is that relay.loadMore(4) leads to the correct data being fetched from the server, but the props of the pagination component never get updated. This repo currently has the same wrong behavior.

In the picture you can see the 2nd correct fetch and the old items on the pagination

Anybody got any Idea?

[AndreiCalazans]

Hello @luongthanhlam I just pushed a fix to that repo.

The problem was that We weren't setting the arguments for filter, therefore on the refetch it was calling it as null which broke the refetch.

here is the fix https://github.com/AndreiCalazans/hackernews-react-relay/blob/f4893c6faa7065e4a1b2be2aa4bdb5199d758e0a/src/components/LinkList.js#L159

[sibelius]

another solution would be use use filters: [] on @connection directive

https://github.com/AndreiCalazans/hackernews-react-relay/blob/f4893c6faa7065e4a1b2be2aa4bdb5199d758e0a/src/components/LinkList.js#L116

@connection(key: "LinkList_allLinks", filters: [])

[luongthanhlam]

That fixed it. Thank you for the reply