Relay: error on react native 45 and react 16-alpha.12

[sibelius]

I'm using react-relay 1.0.0
I've upgraded my react native code to RN 45, and it is throwing the following error:

in this line: require('./relayUnstableBatchedUpdates')

var mounted = _this3.mounted;
        if (mounted) {
          var updateProfiler = require('./RelayProfiler').profile('RelayContainer.update');
          require('./relayUnstableBatchedUpdates')(function () {
            _this3.setState(partialState, function () {
              updateProfiler.stop();
              if (isComplete) {
                completeProfiler.stop();
              }
            });
            if (callback) {
              callback.call(
              // eslint-disable-next-line react/no-string-refs
              _this3.refs.component || null, (0, _extends3['default'])({}, readyState, { mounted: mounted }));
            }
          });
        } else {

[joonhocho]

I am still using react-relay/classic, and I just upgraded react-native to v0.45.1 and I started getting the following error:

this._batchUpdate is not a function.

The same error occurs both on [email protected] and [email protected].

[lprhodes]

Seeing this too - have you found any work-arounds?

[juhaelee]

@joonhocho I'm also getting this error, did you resolve it?

[joonhocho]

@lprhodes @juhaelee Not yet. For now, I just downgraded my react-native.

[alloy]

I have fixes for this in a branch that I’m updating as I go through upgrading our app. I’ll move extract these to a PR later today.

[alloy]

Please give #1889 a try (I’m not yet done with the conversion of our app)

[yungsters]

@spicyj helped me debug this. So relayUnstableBatchedUpdates.native.js does the following:

const ReactNative = require('ReactNative');

module.exports = ReactNative.unstable_batchedUpdates;

However, ReactNative gets mapped to react-native which, according to the react-native/package.json, is actually (and confusingly) react-native-implementation.js.

Notice that react-native-implementation.js does not currently export unstable_batchedUpdates, which means that relayUnstableBatchedUpdates is likely coming up as undefined.

@sibelius or @alloy, can you try modifying react-native-implementation.js to export unstable_batchedUpdates and see if this resolves the bug? If so, either you can send a pull request or I can make the change to export it.

Separately, we really need to rename ReactNative.js to something else (e.g. ReactNativeRenderer.js) and rename react-native-implementation.js to ReactNative.js. But that's a separate issue.

[sophiebits]

and rename react-native-implementation.js to ReactNative.js. But that's a separate issue.

To be fair, I suggested ReactNativeEverythingBagel.js.

[yungsters]

@sibelius or @alloy, can either of you see if https://github.com/facebook/react-native/commit/5550a25628fe04899b737597fa06d9bb979b499d helps?

[joenoon]

@yungsters https://github.com/facebook/react-native/commit/5550a25628fe04899b737597fa06d9bb979b499d worked for me so far. I'm in the middle of a big upgrade, so possible I'll run into something else, but so far so good!

[gre]

facebook/react-native@5550a25 works great

[alloy]

@yungsters Been a while, our migration was on hold. I can confirm that that patch fixes the issue 👍

[yungsters]

Perfect.