Refit: Content in ValidationApiException hides Content in derived ApiException

[SWarnberg]

Hi

I think it's a bad design to hide the Content property of the derived class ApiException. The reason is that if you don't catch ValidationApiException but catch ApiException, you expect to get the Content property as string. However, if the real content is a problem+json document, it's null in the ApiException.
A better approach would be to have a new property in the ValidationApiException class that returns the ProblemDetails and keep Content as text, giving the client a chance to deserialize the problem itself.

Staffan

[DrakeLambert]

I'm having this exact issue right now. Took me 30 minutes to finally track down this issue.

[jamiehowarth0]

It's because the request object is disposed when catching the exception. I'll look at how to do this in a better fashion.

[DrakeLambert]

@jamiehowarth0 See my PR!

[winterdouglas]

I'm facing this exact same issue.