Refined-github: CI Job Status hidden behind commits

Created on 22 May 2020  ·  10Comments  ·  Source: sindresorhus/refined-github

open a commit stream which contains greyed-out commits, like

grafik

hover the first commit to get it into the foreground and click the "X" for the CI status:

grafik

the checks panel is hidden behind the greyed-out commits

occured on google chrome canary 85.0.4150.0 with refined github 20.5.21

bug good first issue help wanted

All 10 comments

Why are the greyed-out merge commits in your case collapsed. We don't collapse them, we only change their opacity (source).

Disable other extensions to see if they might be interfering with commits listing.

(Example URL to test: https://github.com/substack/tape/commits/master)

Why are the greyed-out merge commits in your case collapsed. We don't collapse them, we only change their opacity (source).

tried disabling other extensions, but it seems only refined github is the cause.

collapsing might be a github native feature, when commit messages are "long enough"

We do collapse them in the “dim bots” feature. Disable it if you use bots

But yeah we need to drop overflow:hidden once it uncollapses to avoid the CI panel being clipped

https://github.com/sindresorhus/refined-github/blob/38b48a560b339610461b4acdcf8192ca3cd349e9/source/features/dim-bots.css#L33-L38

/* Dont hide the CI Job Status on focus*/
.rgh-dim-bot.Box-row.navigation-focus {
    overflow: inherit;
}

Adding this after that seems to work

The overflow is required during the animation or else the content will be outside the box. That code simply drops the overflow: hidden

@fregante Would a possible solution to this issue be to listen for the end of the transition, catch that event and just remove the overflow attribute with JavaScript?

If so, I would like to try to implement that in this case :)

I think this can be done with transition delays, no js needed

I can try to fix that if no one else suddenly volunteers :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hkdobrev picture hkdobrev  ·  3Comments

Arcanemagus picture Arcanemagus  ·  3Comments

fregante picture fregante  ·  3Comments

MilesBHuff picture MilesBHuff  ·  3Comments

olso picture olso  ·  3Comments