Refined-github: "View file" is broken when using RefinedGithub

Created on 22 May 2020  路  6Comments  路  Source: sindresorhus/refined-github

As a reproduction case, click View file in the dropdown here:
https://github.com/yuzu-emu/yuzu/pull/3976/files

This causes me to end up on
https://github.com/yuzu-emu/yuzu/blob/qdarkstyle_fix_prop/dist/qt_themes/qdarkstyle/style.qss whereas it should lead me to
https://github.com/yuzu-emu/yuzu/blob/ea14af2164934faa0761a88c6236b3652d8cdaea/dist/qt_themes/qdarkstyle/style.qss.

This issue doesn't occur when the plugin is not installed.

bug

All 6 comments

@FearlessTobi my fault, it was fixed already and was released.

However it may take a day or 2 for it be published the chrome store.

https://github.com/sindresorhus/refined-github/pull/3111

Thanks for the info and my bad for not checking the PR list beforehand. :D

Thanks for developing this awesome plugin!

@FearlessTobi update the extension. It looks like it published already!

Not your fault, I think the issue has been there forever, but I just noticed it when reviewing your PR 馃槂

I don't want to open a new issue for this and I'm not sure if this fixed already from glancing at the commit history, but "View file" seems to be broken again.

For example here https://github.com/yuzu-emu/yuzu/pull/3953/files#diff-41128cb4d8543fc3dc355acefa28cd61L137, it redirects me to https://github.com/GodKratos/yuzu/src/yuzu/main.cpp whereas it should lead to https://github.com/yuzu-emu/yuzu/blob/60b184377ee15e487e630a3cadc18f3c1b4312b3/src/yuzu/main.cpp.

I know about it and I have a fix for it. The issue is only for PR's opened from the default branch.
I am waiting for after https://github.com/sindresorhus/refined-github/pull/3152

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shivapoudel picture shivapoudel  路  3Comments

Celthi picture Celthi  路  3Comments

MilesBHuff picture MilesBHuff  路  3Comments

alexanderadam picture alexanderadam  路  3Comments

hkdobrev picture hkdobrev  路  3Comments