Refined-github: Repo page completely broken when new feature preview enabled

Created on 12 May 2020 · 12Comments · Source: sindresorhus/refined-github

Enable this feature preview: https://gist.github.com/broccolini/2245234ac3a4936049e8ffc13f376986. Go to a repo front page and you'll see a brief flash of content before it's all wiped out.

Please! ♥︎ bug help wanted

Source

SUPERCILEX

👍4

Most helpful comment

How long does that usually take?

Depends on their mood. Anywhere from an hour to a week.

yakov116 on 19 Jun 2020

😄2 👍2 😕1

All 12 comments

The New GitHub UI causes tons of errors in console, here is the UI update

more-dropdown → TypeError: Cannot read property 'append' of null
edit-readme → TypeError: Cannot read property 'textContent' of null
repo-age → TypeError: Cannot read property 'append' of null
edit-files-faster → TypeError: Cannot read property 'textContent' of null
latest-tag-button → TypeError: Cannot read property 'textContent' of null

isaacrlevin on 2 Jun 2020

👍1

Interestingly, I haven't seen RGH wipe out the page completely. (Firefox 76, Refined GitHub 20.5.27)

The console errors I get are different too:

more-dropdown → TypeError: "parent is null"
edit-readme → TypeError: "The element wasn’t found, the selector needs to be updated."
edit-files-faster → TypeError: "The element wasn’t found, the selector needs to be updated."
repo-age → TypeError: "commitInfo is undefined"

latest-tag-button seems to work for me.

Here's the list of features I have disabled:

disabled features in <a href="about:addons">about:addons</a>

auscompgeek on 3 Jun 2020

👍1

I get similar errors in the new design:

aminya on 11 Jun 2020

Sizes need to be updated too:

I think it's only a matter of adding if branchselector.is('.btn-sm'), mybutton.classList.add('btn-sm')

_Originally posted by @fregante in https://github.com/sindresorhus/refined-github/pull/3205#issuecomment-641926371_

fregante on 12 Jun 2020

@fregante I think we can close this issue now, as all the reported console errors (and more that was noticed) are fixed now. The only problems left have separate issues (#3204 and #3215).

If more problems come up, they should get separate issues anyway to track them more efficiently.

FloEdelmann on 18 Jun 2020

🎉1

Thanks for fixing these, Flo!

fregante on 18 Jun 2020

🎉2

Awesome, now push it to the extension store ;)

isaacrlevin on 18 Jun 2020

It was, 3 hours ago. https://github.com/sindresorhus/refined-github/releases/tag/20.6.18
You just need to wait for chrome to release

yakov116 on 18 Jun 2020

It was, 3 hours ago. https://github.com/sindresorhus/refined-github/releases/tag/20.6.18
You just need to wait for chrome to release

How long does that usually take?

sridhar-vadlamani-ck on 19 Jun 2020

How long does that usually take?

Depends on their mood. Anywhere from an hour to a week.

yakov116 on 19 Jun 2020

😄2 👍2 😕1

Still seeing issues opening this page https://github.com/dotnet/winforms/pull/3525/files in in v20.6.25

refined-github.js:2841 ❌ Refined GitHub → more-dropdown → TypeError: Cannot read property 'append' of null
    at appendBefore (refined-github.js:3195)
    at createDropdown (refined-github.js:3209)
    at more_dropdown_init (refined-github.js:3222)
    at async runFeature (refined-github.js:2863)
    at async setupPageLoad (refined-github.js:2871)

I have disabled all other extensions to be sure too.

RussKie on 30 Jun 2020

Still seeing issues opening this page #3525 (files) in in v20.6.25

refined-github.js:2841 ❌ Refined GitHub → more-dropdown → TypeError: Cannot read property 'append' of null
    at appendBefore (refined-github.js:3195)
    at createDropdown (refined-github.js:3209)
    at more_dropdown_init (refined-github.js:3222)
    at async runFeature (refined-github.js:2863)
    at async setupPageLoad (refined-github.js:2871)

I have disabled all other extensions to be sure too.

This is being tracked here: https://github.com/sindresorhus/refined-github/issues/3215