Refined-github: `default-branch-button` on forks: add secondary button to see folder on source repo

[fregante]

1. Visit https://github.com/fregante/refined-github/blob/incremental-tag-changelog-link/source/background.ts
2. There should be a << link to https://github.com/sindresorhus/refined-github/blob/master/source/background.ts

Example: (ignore the arrow)

How:

1. Edit the get-default-branch function to accept a user/repo string (and it should only use parseBranchFromDom if the string matches the current page)
2. Add the button on forks using the CSS code here: https://github.com/sindresorhus/refined-github/pull/1132

More issues semi-related to this one: https://github.com/sindresorhus/refined-github/pull/1115 https://github.com/sindresorhus/refined-github/pull/1168 https://github.com/sindresorhus/refined-github/pull/1557

[yakov116]

I just realized that Unrelated Feature 😄 it exactly this!

Can I have a go for it?

Played around:

Version 1

Version 2

Version 3

[fregante]

Version 4

No extra UI

[fregante]

Edit the get-default-branch function to accept a user/repo string (and it should only use parseBranchFromDom if the string matches the current page)

This is still valid and should be read.

[yakov116]

Part of default branch or its own feature?

[fregante]

fork-source-link-same-view

[fregante]

Edit the get-default-branch function to accept a user/repo string (and it should only use parseBranchFromDom if the string matches the current page)

Perhaps we can skip this and keep it simple by using HEAD as previously suggested.

[yakov116]

I think so, it kept it very simple and it follows the way we did it for forked to.
However its your call chief

[yakov116]

Edit the get-default-branch function to accept a user/repo string (and it should only use parseBranchFromDom if the string matches the current page)

This is still valid and should be read.

i lost you with this one, how would this be different that using HEAD?

[muescha]

Variant 5:

or with master branch:

then it is more clear that i can jump to a specific file or i can use the breadcrump higher directory to jump to this directory

because i think the link forked from ..../.... gets a blind spot because i tried it many times, but then i see this link is useless for me in this case to jump to the same file...

[yakov116]

gets a blind spot because i tried it many times

Happened to me today while trying out the feature.

In other words you dont realize you changed repo's since the page looks the same.

@fregante what if we add it any only alt?

[yakov116]

I made a POC
https://github.com/yakov116/refined-github/tree/fork-source-link-same-view

Variant 5:

I think that will get too noisy on long paths

[muescha]

long path also in a much bigger font above the file, so it is the same "noice" as the file name above the file, but in very small size

[fregante]

I made a POC

This feature is 1 line long. No delegate needed.

const forkSource = select('fork source link')!;
forkSource.pathname = createLink(forkSource.textContent);

... ish, I think you'll need GitHubURL to replace the branch as well

[yakov116]

If we change the pathname we mess up this line
https://github.com/sindresorhus/refined-github/blob/ebeb9903c6ddeac0e9d425753b79bedbd2357321/source/features/forked-to.tsx#L20

[fregante]

If we change the pathname we mess up this line

export function getForkedRepo(): string | undefined {
-   return select<HTMLAnchorElement>('.fork-flag a')?.pathname.slice(1);
+   return select<HTMLAnchorElement>('.fork-flag a')?.pathname.slice(1).split('/', 2).join('/');
}