Refined-github: Console Errors

[yakov116]

• [x] When clicking on almost any dropdown

content.js:4477 Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
    at content.js:4477

Go to any PR start commenting and refresh the page

content.js:808 Uncaught (in promise) TypeError: elements is not iterable
    at Function.watchAndFit [as watch] (content.js:808)
    at enable (content.js:7545)
    at fitPrCommitMessageBox (content.js:7553)
    at HTMLDocument.<anonymous> (content.js:5818)
watchAndFit @ content.js:808
enable @ content.js:7545
fitPrCommitMessageBox @ content.js:7553
(anonymous) @ content.js:5818
async function (async)
(anonymous) @ content.js:5817
so @ session-resume.esm.js:144
(anonymous) @ session-resume.ts:33

```javascript
content.js:8660 Uncaught (in promise) TypeError: Cannot read property 'dispatchEvent' of null
at triggerValidation (content.js:8660)
at HTMLDocument. (content.js:5818)

The first time you go to any repo

```javascript
content.js:12768 ❌ Refined GitHub: feature `repo-age`

 TypeError: Cannot read property 'src' of undefined
    at content.js:10313
    at async getSet (content.js:2412) 

• [x] Press T on any repo issue page.

content.js:10791 Uncaught (in promise) TypeError: Cannot read property 'rghFileFinderTerm' of null
    at setValueInField (content.js:10791)
    at preserve_file_finder_term_init (content.js:10800)
    at features_run (content.js:2798)
    at content.js:2853
    at content.js:2742

• [x] When editing and creating a new milestone

❌ Refined GitHub → filter-comments-by-you → TypeError: Cannot read property 'cloneNode' of null
    at filter_comments_by_you_init (refined-github.js:8380)
    at features_run (refined-github.js:5917)
    at refined-github.js:5972
    at refined-github.js:5861 
Search issue: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+Cannot%20read%20property%20'cloneNode'%20of%20null

refined-github.js:4113 ❌ Refined GitHub → hide-issue-list-autocomplete → TypeError: Cannot read property 'setAttribute' of null
    at hide_issue_list_autocomplete_init (refined-github.js:9478)
    at features_run (refined-github.js:5917)
    at refined-github.js:5972
    at refined-github.js:5861 

The issue is here
https://github.com/sindresorhus/refined-github/blob/d757f50ba6ae5b01638f572fcd59665706e0cdf5/source/libs/page-detect.ts#L260

[fregante]

Are you on master or on the store version? Specifically for the watchAndFit error

[yakov116]

@fregante both

[yakov116]

content.js:12768 ❌ Refined GitHub: feature `repo-age`

 TypeError: Cannot read property 'src' of undefined
    at content.js:10313
    at async getSet (content.js:2412) 

The issue is that element ready is firing too early and responding undefined

[fregante]

Is it https://github.com/sindresorhus/element-ready/issues/29?

[yakov116]

2 new ones
When editing and creating a new milestone and editing a template templates/edit

❌ Refined GitHub → filter-comments-by-you → TypeError: Cannot read property 'cloneNode' of null
    at filter_comments_by_you_init (refined-github.js:8380)
    at features_run (refined-github.js:5917)
    at refined-github.js:5972
    at refined-github.js:5861 
Search issue: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+Cannot%20read%20property%20'cloneNode'%20of%20null

refined-github.js:4113 ❌ Refined GitHub → hide-issue-list-autocomplete → TypeError: Cannot read property 'setAttribute' of null
    at hide_issue_list_autocomplete_init (refined-github.js:9478)
    at features_run (refined-github.js:5917)
    at refined-github.js:5972
    at refined-github.js:5861 

The issue is here
https://github.com/sindresorhus/refined-github/blob/d757f50ba6ae5b01638f572fcd59665706e0cdf5/source/libs/page-detect.ts#L260

Don't know regex that well to be able to fix it

The issue is that if we don't change the regex and change the features it will make silent errors. Is that ok?

[fregante]

Template of what?

[yakov116]

Issue

[fregante]

I'm working on fixing the issue on milestones/new

[yakov116]

Another one https://github.com/sindresorhus/eslint-plugin-unicorn/pull/654

refined-github.js:4104 ❌ Refined GitHub → bypass-checks → TypeError: Failed to fetch 

Really any pull request there. codecov is not authenticated

[fregante]

Don't add too many reports in one issue or else they'll be lost. Open a new one for that

[yakov116]

I know this issue is closed but I think until sindresorhus/element-ready#29 is resolved

content.js:12768 ❌ Refined GitHub: feature `repo-age`

 TypeError: Cannot read property 'src' of undefined
    at content.js:10313
    at async getSet (content.js:2412) 

The issue is that element ready is firing too early and responding undefined

https://github.com/sindresorhus/refined-github/blob/453d3f8566695ce1ea7edd729fb319084bdb7fc2/source/features/repo-age.tsx#L19

Could be changed to

const commitInfo = await elementReady<HTMLAnchorElement | HTMLScriptElement>('a.commit-tease-sha, include-fragment.commit-tease', {
        stopOnDomReady: false,
        timeout: 1000
    });

This would also have the repo age show on first run

JMHO