Refined-github: `show-whitespace` doesn’t work on newly sent suggestions

[szmarczak]

[szmarczak]

No, I checked that for PRs (hence the "start a review" button).

[szmarczak]

Checked again, the issue still persists.

[szmarczak]

I am only seeing it on the PR Files Tab.

That's what I'm talking about... Files changed... I guess I could've said that at the beginning :P

[fregante]

While looking for this I figured out an easy way to see GitHub's event names:

d = Node.prototype.dispatchEvent;
Node.prototype.dispatchEvent = function (...a) {
    console.log(...a);
    // debugger; // Uncomment when necessary
    d.apply(this, a);
}

[fregante]

Anyway, no special events seem to be available. The only solution I can think of:

o = new MutationObserver(runUpdates);

for commentHolders of select.all('.diff-table tbody, .js-comments-holder')
    o.observe(commentHolders, {childList: true})

This should probably be part of on-new-comments somehow. After #2987

[fregante]

I really think that https://github.com/sindresorhus/refined-github/issues/3084 should fix all of our problems, it should be revisited: https://github.com/sindresorhus/refined-github/pull/3092

That PR probably just needs an efficient mechanism to avoid applying changes to the same element.

[notlmn]

@fregante any reason we can't listen on socket:message events and handle everything from there?

[fregante]

If it works, sure, but I think updates can happen seconds _after_ the event.