Refined-github: Comment edit icon hides in the dots menu after you react to a comment

Created on 26 Nov 2019  Â·  5Comments  Â·  Source: sindresorhus/refined-github

  1. yes, it's Refined GitHub
  2. Happens in all repos
  3. screenshots below

before

image

after

image

bug help wanted

Most helpful comment

@fregante

https://github.com/sindresorhus/refined-github/blob/073b65379a8e5f6a6cb1597b2339416d30a25686/source/libs/on-new-comments.ts#L44

Adding subtree: true will work it would also fix #2852

Is this a good idea or allowing it to run on subtree is too much?

To give you an example, clicking the add reaction button will fire edit-comments-faster 8 times

All 5 comments

Other features also affected by this:

  • show-names
  • shorten-links
  • reaction-avatars (... strange, I thought I fixed this in #2533!)

@fregante

https://github.com/sindresorhus/refined-github/blob/073b65379a8e5f6a6cb1597b2339416d30a25686/source/libs/on-new-comments.ts#L44

Adding subtree: true will work it would also fix #2852

Is this a good idea or allowing it to run on subtree is too much?

To give you an example, clicking the add reaction button will fire edit-comments-faster 8 times

subtree isn't allowed, our events needs to be specific, I don't want to listen to every change on the page.

Any other idea's?

https://github.com/sindresorhus/refined-github/blob/073b65379a8e5f6a6cb1597b2339416d30a25686/source/libs/on-updatable-content-update.ts is my last attempt at handling ajaxed contentainers, but I'm not sure if would work in this case.

Ideas come from looking for events in GitHub's code. Sometimes we use those events to start observing new elements.

Was this page helpful?
0 / 5 - 0 ratings