Refined-github: Popups on PRs hidden behind content

[mpaw]

All popup windows inside of PRs (Reviewers, Assignees, Labels, etc...) get hidden behind the content in the main area. Have confirmed issue does not happen when Refined Github is disabled. This also only happens on Github Enterprise, does not happen on github.com

Also, in case it is relevant, we are running GitHub Enterprise Server 2.17.5

[philmcardle]

If it helps, also seeing this on GitHub Enterprise 2.15.3, with refined-github 19.9.17

Tried disabling a number of individual features today in hopes of narrowing it down, but haven't had any luck.

Please let me know if there's anything I can do to help find the cause of or fix for this 🙂

[fregante]

I don't use Enterprise so it's hard to see what's wrong. Perhaps it's sticky-discussion-sidebar but this issue can only be fixed if a GHE user sends a PR.

[philmcardle]

Oh, it is sticky-discussion-sidebar 🙂

[busches]

If you send a PR I can test it in GH and GHE, otherwise it'll be a few
weeks before I can look at it.

On Wed, Sep 18, 2019, 4:29 AM Phil McArdle [e-mail] wrote:

Oh, it is sticky-discussion-sidebar 🙂

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/refined-github/issues/2409?email_source=notifications&email_token=AAGRMZDUEUERC4KO6FJIJNLQKHYIBA5CNFSM4IUKOM3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67OEJA#issuecomment-532603428,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGRMZF3PCD34C5EGAO6DHLQKHYIBANCNFSM4IUKOM3A
.

[Jarvvski]

I can have a look at this after work today :)

[kamranayub]

Hi, maybe this helps! It looks like .discussion-sidebar is missing position: relative for z-index to take effect. Once I add that, z-index is working:

https://<ghe url>/app/app/assets/stylesheets/components/discussion-timeline.scss

[jvtrigueros]

I've confirmed that @kamranayub solution does fix it. As a workaround, you can add this as Custom CSS in the add-on preferences:

.discussion-sidebar {
  position: relative;
}

[mpaw]

Can confirm that adding @jvtrigueros's CSS to the plugin custom CSS resolves the issue.

[fregante]

Does sticky-discussion-sidebar work on GHE? Does disabling the feature fix the issue?

discussion-sidebar is the old class name (removed in https://github.com/sindresorhus/refined-github/pull/2314)

[mpaw]

@fregante No, sticky-discussion-sidebar does not work on GHE. Can confirm that disabling it also fixes the issue.