Refined-github: `minimize-user-comment` breaks hidden comments

Created on 2 Aug 2019  路  4Comments  路  Source: sindresorhus/refined-github

  1. Visit https://github.com/sindresorhus/refined-github/pull/2146
  2. My first comment is hidden, but minimize-user-comment opens it

Gif of me reloading the page. It shows the hidden comment being unhidden by the feature:

cc @notlmn

bug help wanted

Most helpful comment

It ain't a feature implemented by me if it ain't broke.


hide the comments with [hidden] and our own UI (a simple icon placed by the username

That makes sense, will try to whip up something in the meanwhile using https://octicons.github.com/icon/eye/ for the icon.

All 4 comments

The current hijacking of the GitHub's hidden comments also causes the "Unhide" menu item to appear in comments that the feature hid and viceversa:

I think we should move away from these:

https://github.com/sindresorhus/refined-github/blob/7db0c217842e3eb05a38aefd97743b7f0ea9963e/source/features/minimize-user-comments.tsx#L30-L32

and just hide the comments with [hidden] and our own UI (a simple icon placed by the username, for example):

// Pseudo code used for the gif
$('.timeline-comment-header').addEventListener('click', 
    e => event.currentTarget.nextElementSibling.toggleAttribute('hidden')
)

It ain't a feature implemented by me if it ain't broke.


hide the comments with [hidden] and our own UI (a simple icon placed by the username

That makes sense, will try to whip up something in the meanwhile using https://octicons.github.com/icon/eye/ for the icon.

We all write bugs 馃槂

I think this icon would make more sense as a muted/ignored/minimized status, but we need more of a toggle, so perhaps a simple chevron-right should work. On the left of the username

Was this page helpful?
0 / 5 - 0 ratings