Refined-github: "close and comment" button float left, Easy to make a mistake

Created on 10 Apr 2019  ·  4Comments  ·  Source: sindresorhus/refined-github

This is feedback. And the same record for those in need. [transrated by google]
これはフィードバックです。そして同じように困っている人のための記録です。

Version
19.4.7.1857

It feels like the wrong operation is increased by changing the button position.
ボタン位置の変更によってむしろ誤って操作することが増えたように感じます。

Code in.

https://github.com/sindresorhus/refined-github/blob/0b6c7330c21f8570519143ad3d0decc328d4db47/source/content.css#L476-L478

For now, I turned off like this.
とりあえず私はこのようにオフにしました。
Extensions

enhancement good first issue help wanted under discussion

Most helpful comment

Ah, I misunderstood. We already use float:left to avoid mistakes. What if we colored the button red? Or maybe just the text

All 4 comments

Good idea. We already do this for the “Cancel” buttons when leaving comments and for “Cancel review”

Ah, I misunderstood. We already use float:left to avoid mistakes. What if we colored the button red? Or maybe just the text

GitHub changes works for me. and reconsidered that float: left; is better.
Thank you for the discussion.

_WIP__Add_trigger_modal_by_gn-spawn_·_Pull_Request__47_·_elzup_farm-controller-front

Thanks for following up!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

alexanderadam picture alexanderadam  ·  3Comments

durka picture durka  ·  3Comments

juliocanares picture juliocanares  ·  3Comments

sompylasar picture sompylasar  ·  3Comments

Celthi picture Celthi  ·  3Comments