Refined-github: Do not hide PR reviews verdict (hide-useless-comments)

[anthony-robin]

It seems the new hide-useless-comments feature is too gourmand as it also hides the PR review verdict completely when it has only a reaction comment.

---

Should the PR verdict still be visible by only hiding the comment below ?

Thanks !

[busches]

I would say yes, as what I care about is the X approved these changes. We'll see what others think.

[yakov116]

I would say that the reason for the feature is mainly for issues not PR's.

[tandrewnichols]

We use the thumbs up for review where I work (and almost never do an _actual_ review), so now our thumbs are hidden. I get the goal of this feature, but I think it's too heavy-handed. Limiting it to issues only could be a start. I'd also think limiting it to public repositories could cut down on false negatives. You're not going to have the kind of "me too" spam in a private repo that you'd have in a public one. Also seems like you could maybe limit it to public +1s. Like, if you're a contributor to the project (you have push access), it shouldn't suppress the thumb as it's likely supportive conversation (like, "yes, I agree" or "this looks good") and not just "I like this" or "me too."

[hkdobrev]

An emoji in an approval is always a nice touch!

[fregante]

Nice catch! Yes, PR reviews should definitely be excluded. The logic should have done that already (they are by team members and therefore never hidden) but the "Collaborator" tag doesn't appear there.

Anyway if you can't think of many occasions where PRs get dozens of useless comments, it might be easier to just drop the "isPR" filter.

https://github.com/sindresorhus/refined-github/blob/0a1ee62f83b21b113096fe576b23793dca693cb5/source/features/hide-useless-comments.js#L6

[yakov116]

@bfred-it what about excluding private repo's all together

[fregante]

what about excluding private repo's all together

On private repos everyone is a collaborator, so technically they're already excluded. It should work correctly on public repos anyway.

[tandrewnichols]

Well, then I think that isn't working because the thumb was hidden on a pull request in a private repo on which both I and the commenter are collaborators.

[fregante]

Well, then I think that isn't working

Refer to https://github.com/sindresorhus/refined-github/issues/1543#issuecomment-423378536

It’s not working in reviews because there’s no visible “collaborator” tag. It works correctly for regular comments.

[hkdobrev]

Pull request reviews are green/red if the reviewer has write access and gray if they don't. We can use that.

The problem of spamming with these short comments is definitely reduced with the emoji reactions, but I think when it's happening, PRs are no exception.

[tandrewnichols]

It’s not working in reviews because there’s no visible “collaborator” tag. It works correctly for regular comments.

Define "it works correctly." What is the expected behavior of a thumbs up in a regular comment by a collaborator? Because I thought I was understanding that it should _not_ be hidden, but my experience is that it is.

[yakov116]

@tandrewnichols
https://github.com/sindresorhus/refined-github/blob/0a1ee62f83b21b113096fe576b23793dca693cb5/source/features/hide-useless-comments.js#L17-L21

This will exclude anyone that has a badge. Do you have some kind of example where it is hiding where it should not?

[tandrewnichols]

It's in a private repo, but here's a screen shot:

The thumbs up comes from a user listed under the "Contributors" tab. I don't know what you mean in the previous comment by "has a badge."

[tandrewnichols]

Oh, you mean like this:

or this:

[tandrewnichols]

Looks like #1544 would resolve this anyway?

[fregante]

Yep that badge. If nayrudin is a collaborator but does not have a badge it means that they’re not public members of the organization. If GitHub does not mark it as a collaborator there’s not much we can do.

[tandrewnichols]

I mean, you could ignore private repositories cause _everyone_ is a collaborator. Right?

[fregante]

You’re not wrong 😅

PR welcome to exclude private repos

Also since we’re here, I accept suggestions for a more tactful alternative to “N useless comments”

[fregante]

If I think about it… that 👍 is actually pretty useless. The review is already positive what does 👍 add? 😃 Maybe the selector should be updated to remove just the comment and not the review.