Refined-github: In review page, an individual scroll bar appears on every file

[ewjoachim]

Browser: Firefox 60.0.1
OS: Ubuntu 18.04

Problem: On some (most) review files (both individual commit review and whole PR review, both splitted and unified view), a scroll bar for ~1px appears. This blocks the page-wide scroller (under ubuntu, a scroll action can only affect a single scroll window) so it means I have to scroll 2 or 3 times before there's an effect.

Without refined GitHub

With Refined GitHub

[fregante]

Can't reproduce. Can you find out what's causing it?

[ewjoachim]

I'm seeing an overflow-x: auto on .data.highlight.js-blob-wrapper, if I remove it, the problem goes away, but this directive is present in the original page too.

[fregante]

If it happens only with refined GitHub there must be some other rule that causes the overflow. Perhaps try disabling the diff signs feature

[ewjoachim]

It seems to also go away if I disable .refined-github-diff-signs

[fregante]

I'm guessing that the plus sign is slightly taller than it should be on your system. Perhaps try adding line-height:0.1 to it. I can't fix it from here because it's probably font/os-dependent

[ewjoachim]

Adding

.refined-github-diff-signs .blob-code.blob-code-addition::before {
  line-height: 1.75em;;
}

to my custom CSS solves the issue, indeed, but isn't there a way to make it usable for everyone out of the box ?

1.75em is the value where the + is aligned with the rest of the line, more than 1.8em and it starts overflowing...

[fregante]

Does a smaller value works? I don’t want something “just right”

[ewjoachim]

smaller values all the way to zero work, but then the plus is not aligned with the rest of the line.

[fregante]

Let's try it, 1.75 seems to be working for me too. Do you want to send a PR? No em necessary.

[ewjoachim]

Why not :)

[busches]

Closing this since remove diff signs was removed from RGH. Please comment if you encounter it again and we can reopen.