Refined-github: Make issue status always visible when viewing an issue

[vjpr]

I often find myself scrolling to the top to check whether an issue has been closed.

Even if I visit the issue at the top, I often don't notice the open/closed, or I forget by the time I have read through some comments because I am looking for a specific bug fix or mention of something.

And then there is the case where you navigate to a comment directly.

I also find that when there is a referenced issue at the bottom of the issue I confuse it with the status of the current issue, the "Open" badge next to the referenced issue could be made less prominent/lighter color.

We should add the status to the bar on the right.

[fregante]

Making the current issue status more visible sounds good, but making the others less visibile doesn’t.

[salmanulfarzy]

Something like this ?

| | |
|:-:|:-:|

If we're making issue status sticky,

• Should we also make the right sidebar sticky ?
• What should we do about the issue status and (the related pull request reference) at the top ?
• Is this change applicable to pull request pages ?

[fregante]

Sticky sidebar has been talked about in a separate thread (more info there)

I think it should not be a full replacement of the one in the header because we don’t want race conditions with our extend-issue-status feature. Perhaps showing a red/green/purple circle/corner somewhere would be preferrable.

[Mottie]

I created a userscript that adds the issue status similar to @salmanulfarzy's screenshots, but without the icon.

[salmanulfarzy]

Awesome @Mottie :clap: . But looks like it duplicates the mark as unread button.

[Mottie]

Hmm, that appears to be an issue with Refined GitHub. When the discussion sidebar is modified, it adds the mark unread button without checking to see if one is already there (ref).

[styfle]

I solved this for myself by making the entire header "sticky" using the following CSS.

CSS

#partial-discussion-header {
  position: sticky;
  top: 0px;
  z-index: 1;
  background: #fff;
}

.gh-header-meta {
  border-bottom:0px;
}

.gh-header-meta:before {
  content: "";
  position: absolute;
  left: 0;
  bottom: 0;
  height: 1px;
  width: 700px;
  margin-left: 60px;
  border-bottom: 1px solid #e6ebf1;
}

Screenshot

Note the "Make issue status always visible when viewing an issue" title and the "Open" indicator stick to the top as you scroll down 😄

[fregante]

Well, look at this beauty by GitHub :)

It doesn't seem to be always enabled (they're probably a/b testing it)

[lukehefson]

Well, look at this beauty by GitHub :)

[image]

Hehe, you got us 😉.

Just shipped!: https://blog.github.com/changelog/2019-01-04-sticky-coversation-headers/ 🚀

Thanks (as ever) to y'all for helping to inspire us with this one 💛