Refined-github: Explore link has been moved

Created on 23 Aug 2017  Â·  4Comments  Â·  Source: sindresorhus/refined-github

  • In the function moveMarketplaceLinkToProfileDropdown(), a "Explore" link in the drobdown is wanted.

https://github.com/sindresorhus/refined-github/blob/04f3763c3d41dc3687d7d6c11a5b3b2d87cded3d/src/content.js#L109-L113

  • But this link is not anymore in the dropdown, and has been moved to the navbar.

image

  • Then an error is raised in the console.
chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/content.js:650 Uncaught (in promise) TypeError: Cannot read property 'insertAdjacentElement' of null
    at moveMarketplaceLinkToProfileDropdown (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/content.js:650)
    at onDomReady (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/content.js:843)
    at <anonymous>

The side note is that following js tweaks are not processed…

bug enhancement

Most helpful comment

I've been mostly AFK for awhile, so I didn't see this. I've now disabled this feature to make Refined GitHub work again until we can fix it for real. And done a new release.

All 4 comments

Thanks for the report! Can you send a PR to fix this?

I would love to, but it depends on how you want to manage this change:

  • Simply remove the function?
  • Add the link after another item? (but which one?)

I've been mostly AFK for awhile, so I didn't see this. I've now disabled this feature to make Refined GitHub work again until we can fix it for real. And done a new release.

@LeoColomb Should be placed after "Your Gists" with a divider between. Like this:

screen shot 2017-08-24 at 12 45 10

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Celthi picture Celthi  Â·  3Comments

sompylasar picture sompylasar  Â·  3Comments

vanniktech picture vanniktech  Â·  3Comments

juliocanares picture juliocanares  Â·  3Comments

alexanderadam picture alexanderadam  Â·  3Comments